[feat]予算支出ページの年度切り替え実装 #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TkymHrt
reviewed
Feb 22, 2024
| <tr | ||
| key={budgetView.budget.id} | ||
| className={clsx( | ||
| index !== budgets.length - 1 && 'border-b', |
There was a problem hiding this comment.
Suggested change
| index !== budgets.length - 1 && 'border-b', | |
| budgets && index !== budgets.length - 1 && 'border-b', |
budgetsがnullなときにエラーが出ていました！
| <tr | ||
| key={expenseView.expense.id} | ||
| className={clsx( | ||
| index !== expenses.length - 1 && 'border-b', |
There was a problem hiding this comment.
Suggested change
| index !== expenses.length - 1 && 'border-b', | |
| expenses && index !== expenses.length - 1 && 'border-b', |
同様に、expensesがnullなときにエラーが出ていたためです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #676
概要
画面スクリーンショット等
テスト項目
/budgets/details/{year}で取得できるか確認備考