Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] 年度別に支出の選択欄を選べるように変更 #710

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

hikahana
Copy link
Collaborator

@hikahana hikahana commented Mar 19, 2024

対応Issue

resolve #708

概要

購入申請ページの新規登録モーダルにて、支出欄を年度別に切り替えられるようにしました

画面スクリーンショット等

  • URL
    スクリーンショット

テスト項目

  • purchaseoordersの登録をクリックし、購入したい局、団体が年度別によって切り替わるか

備考

適当にpropsを投げまくっているためコードよく見てほしいです

@github-actions github-actions bot added the bug Something isn't working label Mar 19, 2024
@hikahana hikahana self-assigned this Mar 20, 2024
Copy link
Collaborator

@Kubosaka Kubosaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

支出を最新の年度を選択肢にしてください

Comment on lines 105 to 108
console.log(selectedYear);
console.log(props.expenses);
console.log(parseInt(props.selectedYear));
console.log(props.yearPeriods);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consoleのログを消してください

@Kubosaka
Copy link
Collaborator

年度で支出を取得するAPIを作成して
expense_repositoryのAllByPeriodメソッドをusecaseで使えばできそう

Copy link
Collaborator

@Kubosaka Kubosaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APIは問題ないです。
取得したexpensesがnullの場合、登録ボタンを押すとエラー起きるので、対応してほしいです。
例:最新の年度を作成した際に、まだexpenesが未登録の場合など

@Kubosaka Kubosaka merged commit c2dd3bc into develop Apr 1, 2024
@Kubosaka Kubosaka deleted the fix/hikahana/708-purchaseorder-periods-filter branch April 1, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

購入申請の申請を年度別にフィルタリングする
2 participants