一般ユーザーは募金ページを閲覧不可にした #799
Merged
一般ユーザーは募金ページを閲覧不可にした #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikahana
reviewed
Jun 26, 2024
mysql/db/users.sql
Outdated
| @@ -21,4 +21,4 @@ INSERT into users (name, bureau_id, role_id) values ('技大太郎2', 6, 2); | |||
| INSERT into users (name, bureau_id, role_id) values ('技大太郎3', 3, 3); | |||
|
|
|||
| -- 一般ユーザー（財務局員） | |||
There was a problem hiding this comment.
Suggested change
| -- 一般ユーザー（財務局員） | |
| -- 財務局員 |
上の方で財務局長となっているので名称合わせてもいいかもですね
There was a problem hiding this comment.
修正しました
[fix]コメントの修正
There was a problem hiding this comment.
応急処置としてですが、
レンダリングされてからrouter.pushでページ遷移されるから一瞬だけ見えちゃうので
286行目にroleIDが1の時表示させない処理を追加した方よさげかも
{fundInformationViews &&
user.roleID !== 1 &&
fundInformationViews.map((fundViewItem: FundInformationView, index) => (
There was a problem hiding this comment.
修正しました
[feat]一般ユーザー場合データを非表示にする
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #798
概要
テスト項目
備考