[feat]フィルタありのactivitesのAPI実装 #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubosaka
reviewed
Jul 5, 2024
|
yearだけ |
Kubosaka
reviewed
Jul 6, 2024
Comment on lines
226
to
227
| WHERE | ||
| 1=1 ` |
There was a problem hiding this comment.
ここっているんですかね？
おそらくWHEREがないとエラーが出るから付けてるかと思います
何も条件がない場合にWHEREをつける形とかだとできますかね
There was a problem hiding this comment.
今回フィルタに使用している要素がすべて任意で外すことができるため、どの要素からWHEREが始まるかわからないため、1=1の常にTRUEの条件を設定し、そのあとにそれぞれのフィルタを加えるように実装しています。
| years | ||
| ON | ||
| year_periods.year_id = years.id | ||
| WHERE |
There was a problem hiding this comment.
Suggested change
| WHERE | |
| WHERE |
スペースを消してください
|
|
||
| // keywordフィルタを追加 | ||
| if keyword != "" { | ||
| query += ` AND |
There was a problem hiding this comment.
Suggested change
| query += ` AND | |
| query += ` AND |
| // isDoneフィルタを追加 | ||
| if isDone != "" { | ||
| if isDone != "all" { | ||
| query += ` AND |
There was a problem hiding this comment.
Suggested change
| query += ` AND | |
| query += ` AND |
| if len(sponsorStyleIDs) > 0 { | ||
| // プレースホルダーを生成 | ||
| placeholders := strings.Join(sponsorStyleIDs, ",") | ||
| query += ` AND |
There was a problem hiding this comment.
Suggested change
| query += ` AND | |
| query += ` AND |
| // activityに紐づくsponserとusersをフィルタを考慮して取得する | ||
| func (ar *activityRepository) FindFilteredDetail(c context.Context, isDone string, sponsorStyleIDs []string, year string, keyword string) (*sql.Rows, error) { | ||
| query := ` | ||
| SELECT |
There was a problem hiding this comment.
Suggested change
| SELECT | |
| SELECT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #800
概要
画面スクリーンショット等
URLスクリーンショット
テスト項目
make buildをするmake upで立ち上げるlocalhost:1323/swaggerでSwaggerを開くsponsoractivites/filtered_detailsのAPIで適当に動かし、動作確認をする。備考