Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 年度別で募金登録済みの教員Idを配列で返すAPIの作成 #818

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

hikahana
Copy link
Collaborator

@hikahana hikahana commented Jul 2, 2024

対応Issue

resolve #815

概要

disabledを掛けるためにfund_informationに登録されているteacher.idを取得しました。
取得したidは配列で返すようにしています。このままフロントで使えると思います。

画面スクリーンショット等

  • URL
    スクリーンショット
    image

テスト項目

  • swaggerを開いて、/teachers/fundRegistered/{year}にとんでください
  • yearパラメータに2024と入力して、スクショのような結果が返ってくるか
  • 他のパラメータを指定してもシーズデータに存在しないためnullが返ってきます

備考

命名てきとうにしたので要確認でお願いします

@hikahana hikahana added enhancement New feature or request backend labels Jul 2, 2024
@hikahana hikahana requested a review from Kubosaka July 2, 2024 17:38
@hikahana hikahana self-assigned this Jul 2, 2024
Copy link
Collaborator

@Kubosaka Kubosaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

件数が0の時、[ ]か404番で返した方がいいかと思います
スクリーンショット 2024-07-03 22 56 36

@Kubosaka
Copy link
Collaborator

Kubosaka commented Jul 3, 2024

動作は問題ないです!

Copy link
Collaborator

@Kubosaka Kubosaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubosaka Kubosaka merged commit 91a682b into develop Jul 7, 2024
1 check passed
@Kubosaka Kubosaka deleted the feat/hikahana/815-create-teachers-not-selectable branch July 7, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

既に募金登録されている教員を選択不可能APIの作成
2 participants