Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

既存コンポーネントをStorybook上に表示する（/common） #857

Merged
merged 7 commits into from
Jul 27, 2024
Merged

既存コンポーネントをStorybook上に表示する（/common） #857

merged 7 commits into from
Jul 27, 2024

Conversation

Ryotakobayash
Copy link
Collaborator

対応Issue

resolve #856

概要

  • 過去に実装したcommonのstoriesファイルをフォルダ分けする
  • 過去に実装した時未着手だったコンポーネントのstoriesファイルを作成する。

画面スクリーンショット等

image

テスト項目

以下のファイルを表示できるか

  • ChakraUlDropdown.tsx
  • CloseButton.tsx
  • DeleteButton.tsx
  • Dropdown.tsx
  • EditButton.tsx
  • LoadingButton.tsx
  • Modal.tsx
  • OpenModalButton.tsx
  • PulldownButton.tsx
  • RegistButton.tsx
  • RegistModal.tsx
  • SideNav.tsx
  • Stepper.tsx
  • Title.tsx
  • AddButton
  • BureauLabel
  • Button
  • Card
  • Checkbox
  • Header
  • Input
  • Label
  • Link
  • Loading
  • MultiSelect
  • OutlinePrimaryButton
  • PrimaryButton
  • PrimaryLink
  • PullDown
  • Radio
  • RedButton
  • SearchSelect
  • Select
  • Textarea
  • Tooltip
  • UnderlinePrimaryButton

備考

@Ryotakobayash Ryotakobayash requested a review from Kubosaka July 26, 2024 06:47
@Kubosaka Kubosaka assigned Kubosaka and Ryotakobayash and unassigned Kubosaka Jul 27, 2024
Kubosaka
Kubosaka approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@Kubosaka Kubosaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubosaka Kubosaka merged commit 4cf8dc4 into develop Jul 27, 2024
3 checks passed
@Kubosaka Kubosaka deleted the feat/kobayashi/CreatingstoriesFile/common-856 branch July 27, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubosaka Kubosaka Kubosaka approved these changes

Assignees

@Ryotakobayash Ryotakobayash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

既存コンポーネントをStorybook上に表示する（/common）前回の残り
2 participants
@Ryotakobayash @Kubosaka