[予算管理]局APIの作成 #907
Merged
[予算管理]局APIの作成 #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubosaka
changed the base branch from
develop
to
feat/kubosaka/intro-orval-generate
Kubosaka
commented
Jan 8, 2025
Comment on lines
+1083
to
+1088
| parameters: | ||
| - name: year | ||
| in: query | ||
| description: year | ||
| schema: | ||
| type: integer |
There was a problem hiding this comment.
クエリパラメータでyearを追加しました
全件取得もできるようにrequiredはつけていないです
| @@ -35,3 +35,6 @@ yarn-error.log* | |||
|
|
|||
| # typescript | |||
| *.tsbuildinfo | |||
|
|
|||
| # genereated | |||
| /src/generated | |||
There was a problem hiding this comment.
生成したコードがgithub actionsのworkflowで整形されると差分が大きくなるので、自動生成分はignoreに入れました
Kubosaka
commented
Jan 8, 2025
Comment on lines
+39
to
+41
| goqu.COALESCE(goqu.SUM("item_budgets.amount"), 0).As("budget"), | ||
| goqu.COALESCE(goqu.SUM("buy_reports.amount"), 0).As("expense"), | ||
| goqu.COALESCE(goqu.L("SUM(item_budgets.amount) - SUM(buy_reports.amount)"), 0).As("balance")). |
There was a problem hiding this comment.
データがNULLの時に0にしたいため、COALESCEを使いました
Closed
hikahana
reviewed
Jan 8, 2025
| } | ||
|
|
||
| type FinancialRecordUseCase interface { | ||
| GetFinancialRecords(context.Context) (generated.FinancialRecordDetails, error) |
There was a problem hiding this comment.
[imo]
何回も呼ばれるから一番下とかにgenerated省略したのて定義したい派閥です。
type FinancialRecordDetails = generated.FinancialRecordDetails
hikahana
reviewed
Jan 8, 2025
| c context.Context, | ||
| ) (generated.FinancialRecordDetails, error) { | ||
| var financialRecordDetails generated.FinancialRecordDetails | ||
| var financialRecordList []generated.FinancialRecordWithBalance |
There was a problem hiding this comment.
financialRecordBalancesかfinancialRecordsとかでも伝わりそう
There was a problem hiding this comment.
hikahana
approved these changes
Jan 9, 2025
| return &financialRecordUseCase{rep} | ||
| } | ||
|
|
||
| type FinancialRecordDetails = generated.FinancialRecordDetails |
There was a problem hiding this comment.
[imo]
個人的ですが一番上か一番下に置いた方が好き。直さなくても〇。
There was a problem hiding this comment.
そのほうが読みやすくなるからですか？
これはマージして次から一番下にします
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #903
概要
year作成したAPI
yearで指定した年度のデータを全件取得画面スクリーンショット等
テスト項目
備考