デプロイ時に出た修正をここにまとめる #289
Merged
デプロイ時に出た修正をここにまとめる #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TkymHrt
reviewed
Sep 5, 2024
| import { Header, PrizeResult, Loading } from "@/components/common"; | ||
| import { IoCloudUploadOutline } from "react-icons/ios"; |
There was a problem hiding this comment.
読み込み先は/io5ですね。
Suggested change
| import { IoCloudUploadOutline } from "react-icons/ios"; | |
| import { IoCloudUploadOutline } from "react-icons/io5"; |
| @@ -26,13 +26,12 @@ const Page: NextPage = () => { | |||
| ); | |||
| const [prizeNameJp, setPrizeNameJp] = useState<string>(""); | |||
| const [prizeNameEn, setPrizeNameEn] = useState<string>(""); | |||
| const fileInputRef = useRef<HTMLInputElement>(null); | |||
| const [imageFile, setImageFile] = useState<File | null>(null); | |||
| const fileInputRef = useRef<HTMLInputElement>(); | |||
There was a problem hiding this comment.
null 入れないとエラー出ませんか？
Suggested change
| const fileInputRef = useRef<HTMLInputElement>(); | |
| const fileInputRef = useRef<HTMLInputElement>(null); |
|
bucketNameにendpoint入れてました。。。。。 |
TkymHrt
reviewed
Sep 8, 2024
view-admin/src/pages/api/minio.ts
Outdated
| if (req.method === "POST") { | ||
| const form = formidable(); | ||
|
|
||
| form.parse(req, async (err: any, fields: any, files: any) => { | ||
| form.parse(req, async (err: any, files: any) => { |
There was a problem hiding this comment.
parseメソッドは第3引数にファイルデータを渡すようなので、使用しない引数も挟まないと動作しないと思われます。
parse<FieldKey extends string, FileKey extends string>(
request: IncomingMessage,
): Promise<[Fields<FieldKey>, Files<FileKey>]>;
parse<FieldKey extends string, FileKey extends string>(
request: IncomingMessage,
callback?: (err: any, fields: Fields<FieldKey>, files: Files<FileKey>) => void,
): void;
Suggested change
| form.parse(req, async (err: any, files: any) => { | |
| form.parse(req, async (err: any, _: Fields, files: Files) => { |
型もany型はできるだけ避けて下記みたいな感じで！
import formidable, { Fields, Files } from "formidable";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
なし、
概要
デプロイ時に発生した修正をここにまとめています。
キックオフ後マージ予定です。
実装詳細
minioの送信を修正
タイポの修正
prod用のmakeの修正
画面スクリーンショット等
テスト項目
備考