Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リーチ数をスクリーンに表示する #290

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

YosukeIida
Copy link
Collaborator

対応Issue

概要

実装詳細

  • userのスクリーンページに現在のリーチ数をリアルタイムで表示機能を追加
  • adminで,リーチ数の増減機能を追加
  • reach_logs テーブルのreachNumをsubscriptionで取得して表示する
  • adminで,リーチ数の最新の値をlazyQueryで取得して,+1 or -1することで増減をする

画面スクリーンショット等

テスト項目

  • スクリーンページに最新のリーチ数が表示されるか確認する
  • adminで,リーチ数が増減できる確認する
  • [ ]

備考

@YosukeIida YosukeIida requested a review from hikahana August 31, 2024 21:35
@YosukeIida YosukeIida self-assigned this Aug 31, 2024
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントした

{/* todo countはAPIとつなぎ込み */}
<ReachCount count={0} />
{/* // TODO オプショナルでエラーを逃れているのを対処する */}
<ReachCount count={reachLog?.reachLogs[0].reachNum || 0} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ReachCount count={reachLog?.reachLogs[0].reachNum || 0} />
<ReachCount count={reachLog?.reachLogs?.[0]?.reachNum || 0} />

Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hikahana hikahana merged commit e6632e1 into develop Aug 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リーチカウントAPIを使用して,screenページでリーチ数を表示
2 participants