-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Release automation #282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrykong
requested changes
Sep 6, 2024
@terrykong could you have a second look? |
terrykong
requested changes
Sep 6, 2024
ko3n1g
force-pushed
the
ko3n1g/ci/release-automation
branch
from
September 19, 2024 05:26
dfedb3a
to
c35aea0
Compare
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Sep 19, 2024
ko3n1g
force-pushed
the
ko3n1g/ci/release-automation
branch
from
September 19, 2024 05:47
1c4ffda
to
b7d0704
Compare
ko3n1g
added
Run CICD
Set + un-set to retrigger
and removed
Run CICD
Set + un-set to retrigger
labels
Sep 19, 2024
ko3n1g
force-pushed
the
ko3n1g/ci/release-automation
branch
from
September 20, 2024 17:00
3afd376
to
e23faa4
Compare
Create a protected environment to hold our PyPi secrets: https://github.com/NVIDIA/NeMo-Aligner/settings/environments |
ko3n1g
force-pushed
the
ko3n1g/ci/release-automation
branch
from
September 22, 2024 06:55
7292224
to
61c351f
Compare
ko3n1g
force-pushed
the
ko3n1g/ci/release-automation
branch
from
September 23, 2024 07:54
3a270a5
to
fb19d5f
Compare
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
ko3n1g
force-pushed
the
ko3n1g/ci/release-automation
branch
from
September 24, 2024 07:59
dc97088
to
93c1cae
Compare
Merging this now since I incorporated @terrykong 's feedback and also tested the shell commands locally during the last release. It ultimately can only be tested "live" anyway, so there's no point in holding this PR back |
abukharin3
pushed a commit
to abukharin3/NeMo-Aligner
that referenced
this pull request
Nov 7, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Implements a manual
workflow_dispatch
that allows us to build, test, and publish a PyPi wheel as well as create GH release (tag).It is secured by a GH environment that runs on
main
(protected) only by a PyPi token that is resolved in this environment only. Put different: If one tries to use this token on a branch other thanmain
it will be empty. So to make use of this token, they need to be able to merge their script into main, which of course only works by review.The release page will be populated by the
CHANGELOG.md
file (awesome that you already have that!!). I extract the section from (incl) to (excl)## ...
blocks as the description of the release page.Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
Checklist when contributing a new algorithm
max_steps=-1
andvalidation
?Additional Information