Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "Merge branch 'dev' into main" #431

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

terrykong
Copy link
Collaborator

This reverts commit 3267060, reversing changes made to c69b872.

Pushing the update branch on #413 actually created a merge commit on main, which should not have been allowed.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

This reverts commit 3267060, reversing
changes made to c69b872.

Signed-off-by: Terry Kong <[email protected]>
@github-actions github-actions bot added the Utils label Dec 4, 2024
@terrykong terrykong changed the title Revert "Merge branch 'dev' into main" revert: "Merge branch 'dev' into main" Dec 4, 2024
@terrykong terrykong added the Run CICD Set + un-set to retrigger label Dec 4, 2024
@terrykong terrykong enabled auto-merge (squash) December 4, 2024 23:03
@terrykong terrykong merged commit 5b07bec into main Dec 4, 2024
18 of 20 checks passed
@terrykong terrykong deleted the tk/revert-github-ui-merging-into-main branch December 4, 2024 23:26
terrykong added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run CICD Set + un-set to retrigger Utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants