-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create separate files for each deduplication class #409
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally in favor of this.
Would also check and update the api docs if needed: https://github.com/NVIDIA/NeMo-Curator/blob/main/docs/user-guide/api/deduplication.rst (not sure if it is or not).
Would also update any nemo-ci scripts if needed to accomodate the changes here.
cc: @VibhuJawa Could you take a look for semdedup as well? |
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviwed the semdedup functions, my only nit pick is to keep the module level import for stuff like ClusteringModel
, EmbeddingCreator
etc because they can also be generic in nature so it is a easier mental model.
@@ -18,10 +18,10 @@ | |||
|
|||
import dask_cudf | |||
|
|||
from nemo_curator import ClusteringModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep this as semnatic dedup specific import (because clustering can be generic). So something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like EmbeddingCreator
, ClusteringModel
, and SemanticClusterLevelDedup
are currently available as generic imports in NeMo Curator: https://github.com/NVIDIA/NeMo-Curator/blob/main/docs/user-guide/api/deduplication.rst
Should I change it to only be importable via nemo_curator.semantic_dedup
instead?
Re-opening #389 because of merge issues.