Handle exception when importing RetroGPTChunkDatasets #11415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guyue Huang <[email protected]>
thomasdhc
previously approved these changes
Dec 2, 2024
|
@JimmyZhang12 could you trigger CICD again, let's get this merged |
|
wait, need to resolve a confict |
This reverts commit 21a4734.
Signed-off-by: guyueh1 <[email protected]>
|
The bot pushed some changes to |
|
@ko3n1g Any idea what the secret baseline update is about? |
I have a bunch what’s going on. I’ll send a fix tmrw |
This reverts commit 8d35fcc.
|
Reverted the commit that changed .secrets.baseline and merged main, let's see if the "Update baseline" commit comes this time |
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
|
@thomasdhc CICD finished, looks good to merge |
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* Handle exception when importing RetroGPTChunkDatasets Signed-off-by: Guyue Huang <[email protected]> * Update baseline Signed-off-by: guyueh1 <[email protected]> * Revert "Update baseline" This reverts commit 21a4734. * Update baseline Signed-off-by: guyueh1 <[email protected]> * Revert "Update baseline" This reverts commit 8d35fcc. --------- Signed-off-by: Guyue Huang <[email protected]> Signed-off-by: guyueh1 <[email protected]> Co-authored-by: guyueh1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Handle exception during import of RetroGPTChunkDatasets
Collection: [Note which collection this PR will affect]
Changelog
Currently on arm linux platform,
from megatron.core.datasets.retro.config import RetroGPTChunkDatasetsfails with an exception which is a known issue with its dependency, faiss. When the exception happens, we want to gracefully fall back to the codepath without megatron retro support.Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information