Bump mcore #11740
Merged
Bump mcore #11740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* remove nvte attention flags from test_nemo_resume_from_ckpt Signed-off-by: Ananth Subramaniam <[email protected]> * cherry pick 3410df6 Signed-off-by: Ananth Subramaniam <[email protected]> * set local attention in config Signed-off-by: Ananth Subramaniam <[email protected]> * retro config attention backend setting Signed-off-by: Ananth Subramaniam <[email protected]> * set both Signed-off-by: Ananth Subramaniam <[email protected]> * update unfused Signed-off-by: Ananth Subramaniam <[email protected]> * gemma2b changes too Signed-off-by: Ananth Subramaniam <[email protected]> * replace more usages Signed-off-by: Ananth Subramaniam <[email protected]> * more test updates Signed-off-by: Ananth Subramaniam <[email protected]> * Apply isort and black reformatting Signed-off-by: ananthsub <[email protected]> * update unfused Signed-off-by: Ananth Subramaniam <[email protected]> * remove duplicate gemma setting Signed-off-by: Ananth Subramaniam <[email protected]> * remove gemma2b fused attn env vars Signed-off-by: Ananth Subramaniam <[email protected]> * local for testing Signed-off-by: Ananth Subramaniam <[email protected]> * update conftest to reset environment variables, use unfused for L2_Megatron_GPT_PEFT_Lora_TP2SP1 Signed-off-by: Ananth Subramaniam <[email protected]> --------- Signed-off-by: Ananth Subramaniam <[email protected]> Signed-off-by: ananthsub <[email protected]> Signed-off-by: oliver könig <[email protected]> Co-authored-by: ananthsub <[email protected]> Co-authored-by: oliver könig <[email protected]>
* chore(beep boop 🤖): Bump `MCORE_TAG=71c394b...` (2024-12-15) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * ci: Add `no-fail-fast` mode Signed-off-by: Oliver Koenig <[email protected]> * fix _get_layer_offset api for mllama Signed-off-by: yaoyu-33 <[email protected]> * bump Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Oliver Koenig <[email protected]> Signed-off-by: yaoyu-33 <[email protected]> Signed-off-by: oliver könig <[email protected]> Co-authored-by: pablo-garay <[email protected]> Co-authored-by: yaoyu-33 <[email protected]>
ko3n1g
changed the title
MCORE_TAG=076972e... (2025-01-03)
due to change in mcore commit NVIDIA/Megatron-LM@31e8bfa Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
ko3n1g
commented
Jan 7, 2025
Comment on lines
98
to
100
| for env_var in ['NVTE_FLASH_ATTN', 'NVTE_FUSED_ATTN', 'NVTE_UNFUSED_ATTN']: | ||
| if env_var in os.environ: | ||
| del os.environ[env_var] |
There was a problem hiding this comment.
our of curiosity: where are the vars set?
There was a problem hiding this comment.
it happens inside megatron, there's no automatic cleanup of the env-vars set in check_and_set_env_variable, therefore I'm doing it manually here.
Signed-off-by: Abhishree <[email protected]>
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
1 similar comment
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
|
[🤖]: Hi @ko3n1g 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
pablo-garay
added a commit
that referenced
this pull request
Jan 8, 2025
This reverts commit 8b9d6c7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 PR to bump
NVIDIA/Megatron-LMinDockerfile.citoMCORE_TAG=076972e37420b5325c5fe06e7131be7d96f05b53.📝 Please remember the following to-do's before merge:
🙏 Please merge this PR only if the CI workflow completed successfully.