In-framework deployment NeMo 2.0 nemo_export.py test #11749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janekl
commented
Jan 3, 2025
| @@ -141,7 +141,7 @@ def query_llm( | |||
| "object": "text_completion", | |||
| "created": int(time.time()), | |||
| "model": self.model_name, | |||
| "choices": [{"text": str(sentences)}], | |||
| "choices": [{"text": sentences}], | |||
There was a problem hiding this comment.
Projecting NumPy array to string makes it hard to recover it later for further processing (note missing comma "," after the first element):
str(np.array([["a"], ["b"]])) == "[['a']\n ['b']]"
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
janekl
force-pushed
the
jlasek/nemo_export_in_framework_test
branch
from
6010096 to
be30d89
Compare
Signed-off-by: janekl <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: janekl <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
ko3n1g
reviewed
Jan 8, 2025
Dockerfile.ci
Outdated
| @@ -72,6 +72,7 @@ pip install --no-cache-dir --no-build-isolation --extra-index-url https://pypi.n | |||
| "llama-index==0.10.43" \ | |||
| "onnxscript @ git+https://github.com/microsoft/onnxscript" \ | |||
| -r tools/ctc_segmentation/requirements.txt \ | |||
| -r requirements/requirements_infer.txt \ | |||
There was a problem hiding this comment.
Would it make sense to embed this into setup.py? What reasons may speak against it?
There was a problem hiding this comment.
Good idea. I can offer sth like 398b0e7
janekl
commented
Jan 9, 2025
| from megatron.core.inference.common_inference_params import CommonInferenceParams | ||
| from pytorch_lightning.trainer.trainer import Trainer |
There was a problem hiding this comment.
This Trainer was deprecated. Using it now leads to the error like:
ValueError: You selected an invalid strategy name: `strategy=<nemo.collections.nlp.parts.nlp_overrides.NLPDDPStrategy object at 0x7f7030512c20>`.
It must be either a string or an instance of `pytorch_lightning.strategies.Strategy`. Example choices: auto, ddp, ddp_spawn, deepspeed, ...
Find a complete list of options in our documentation at https://lightning.ai
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
oyilmaz-nvidia
approved these changes
Jan 10, 2025
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
ko3n1g
reviewed
Jan 10, 2025
janekl
commented
Jan 10, 2025
ko3n1g
approved these changes
Jan 10, 2025
|
[🤖]: Hi @janekl 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adding
nemo_export.py --in-framework True [...]test in Github Actions. This also includes:generatemethod forMegatronLLMDeployableNemo2for parity with NeMo 1.0generateforMegatronLLMDeployableCollection: NLP/ LLM
Usage
See edits in
.github/workflows/cicd-main.yml.GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information