fix sentencepiece tokenizer special tokens #11767
Merged
+68
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/fix_sentencepiece_tokenizer_special_tokens
branch
from
b45e00a to
da653c0
Compare
akoumpa
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/fix_sentencepiece_tokenizer_special_tokens
branch
from
b9af29f to
a895489
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/fix_sentencepiece_tokenizer_special_tokens
branch
from
138caaa to
b9494cc
Compare
Signed-off-by: akoumpa <[email protected]>
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
akoumpa
commented
Jan 6, 2025
| @@ -237,6 +237,9 @@ def add_special_tokens(self, special_tokens): | |||
| self.special_token_to_id[token] = self.vocab_size | |||
| self.id_to_special_token[self.vocab_size] = token | |||
| self.vocab_size += 1 | |||
| elif self.tokenizer.piece_to_id(token) != self.tokenizer.unk_id(): | |||
There was a problem hiding this comment.
if a token is already in the vocab, we want to allow users to mark them as special tokens.
|
[🤖]: Hi @akoumpa 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
akoumpa
deleted the
akoumparouli/fix_sentencepiece_tokenizer_special_tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Special tokens were not passed to sentencepiece library.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information