-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null tokenizer #11789
Add null tokenizer #11789
Conversation
Signed-off-by: Sangkug Lym <[email protected]>
Signed-off-by: erhoo82 <[email protected]>
@@ -0,0 +1,68 @@ | |||
# Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 2025
Signed-off-by: Sangkug Lym <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
[🤖]: Hi @erhoo82 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
* Add null tokenizer Signed-off-by: Sangkug Lym <[email protected]> * Apply isort and black reformatting Signed-off-by: erhoo82 <[email protected]> * cleanup Signed-off-by: Sangkug Lym <[email protected]> --------- Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: erhoo82 <[email protected]> Co-authored-by: erhoo82 <[email protected]>
* Add null tokenizer * Apply isort and black reformatting * cleanup --------- Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: erhoo82 <[email protected]> Co-authored-by: Sangkug Lym <[email protected]> Co-authored-by: erhoo82 <[email protected]>
What does this PR do ?
Add a null tokenizer to ease the runs for performance benchmark and debugging
Changelog
Add a null tokenizer
Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information