Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null tokenizer #11789

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Add null tokenizer #11789

merged 4 commits into from
Jan 9, 2025

Conversation

erhoo82
Copy link
Collaborator

@erhoo82 erhoo82 commented Jan 8, 2025

What does this PR do ?

Add a null tokenizer to ease the runs for performance benchmark and debugging

Changelog

Add a null tokenizer

Usage

tokenizer=run.Config(                                  
    get_nmt_tokenizer,                                  
    library="null",                                   
    model_name = "NullTokenizer",                            
    vocab_size = 256000,
)

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Sangkug Lym <[email protected]>
@erhoo82 erhoo82 requested review from ericharper and removed request for akoumpa January 8, 2025 18:05
@@ -0,0 +1,68 @@
# Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 2025

Signed-off-by: Sangkug Lym <[email protected]>
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

github-actions bot commented Jan 9, 2025

[🤖]: Hi @erhoo82 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@malay-nagda malay-nagda merged commit 3146703 into main Jan 9, 2025
390 of 396 checks passed
@malay-nagda malay-nagda deleted the null_tokenizer branch January 9, 2025 16:24
ko3n1g pushed a commit that referenced this pull request Jan 9, 2025
* Add null tokenizer

Signed-off-by: Sangkug Lym <[email protected]>

* Apply isort and black reformatting

Signed-off-by: erhoo82 <[email protected]>

* cleanup

Signed-off-by: Sangkug Lym <[email protected]>

---------

Signed-off-by: Sangkug Lym <[email protected]>
Signed-off-by: erhoo82 <[email protected]>
Co-authored-by: erhoo82 <[email protected]>
ko3n1g added a commit that referenced this pull request Jan 10, 2025
* Add null tokenizer



* Apply isort and black reformatting



* cleanup



---------

Signed-off-by: Sangkug Lym <[email protected]>
Signed-off-by: erhoo82 <[email protected]>
Co-authored-by: Sangkug Lym <[email protected]>
Co-authored-by: erhoo82 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants