Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 8x22b seq len (11788) into r2.1.1 #11819

Open
wants to merge 1 commit into
base: r2.1.1
Choose a base branch
from
Open

Cherry pick 8x22b seq len (11788) into r2.1.1 #11819

wants to merge 1 commit into from
+17 −7

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jan 10, 2025

beep boop [🤖]: Hi @malay-nagda 👋,

we've cherry picked #11788 into  for you! 🚀

Please review and approve this cherry pick by your convenience!

@malay-nagda
8x22b seq len (#11788)
ee9c86d 
* 8x22b seq len

Signed-off-by: Malay Nagda <[email protected]>

* 8x22b seq len tests

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* 8x22b seq len tests

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
@ko3n1g ko3n1g requested a review from malay-nagda January 10, 2025 19:09
@github-actions GitHub Actions
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.

Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.llm.gpt.model.mixtral
nemo/collections/llm/gpt/model/mixtral.py:158:0: C0301: Line too long (132/119) (line-too-long)
nemo/collections/llm/gpt/model/mixtral.py:298:0: C0301: Line too long (132/119) (line-too-long)
nemo/collections/llm/gpt/model/mixtral.py:119:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/gpt/model/mixtral.py:133:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/gpt/model/mixtral.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:168:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:269:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/gpt/model/mixtral.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:316:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.lightning.run.plugins
nemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)
nemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)
nemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)
nemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)
nemo/lightning/run/plugins.py:183:0: C0301: Line too long (174/119) (line-too-long)
nemo/lightning/run/plugins.py:259:0: C0301: Line too long (150/119) (line-too-long)
nemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:160:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:206:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.37/10

Thank you for improving NeMo's documentation!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.

Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.llm.gpt.model.mixtral
nemo/collections/llm/gpt/model/mixtral.py:158:0: C0301: Line too long (132/119) (line-too-long)
nemo/collections/llm/gpt/model/mixtral.py:298:0: C0301: Line too long (132/119) (line-too-long)
nemo/collections/llm/gpt/model/mixtral.py:119:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/gpt/model/mixtral.py:133:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/gpt/model/mixtral.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:168:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:269:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/gpt/model/mixtral.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/model/mixtral.py:316:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.lightning.run.plugins
nemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)
nemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)
nemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)
nemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)
nemo/lightning/run/plugins.py:183:0: C0301: Line too long (174/119) (line-too-long)
nemo/lightning/run/plugins.py:259:0: C0301: Line too long (150/119) (line-too-long)
nemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:160:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:206:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.37/10

Thank you for improving NeMo's documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malay-nagda malay-nagda Awaiting requested review from malay-nagda

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cherry-pick Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ko3n1g @malay-nagda