[MoE] add expert tensor parallelism support for NeMo2.0 MoE #11880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gdeng <[email protected]>
Signed-off-by: gdeng <[email protected]>
…://github.com/gdengk/NeMo into gaod/moe/add_expert_tensor_parallesim_support
Signed-off-by: gdeng <[email protected]>
Signed-off-by: gdeng <[email protected]>
…://github.com/gdengk/NeMo into gaod/moe/add_expert_tensor_parallesim_support
Signed-off-by: gdeng <[email protected]>
akoumpa
previously approved these changes
Jan 24, 2025
Signed-off-by: gdeng <[email protected]>
auto-merge was automatically disabled
January 26, 2025 21:56
Head branch was pushed to by a user without write access
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
1 similar comment
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
akoumpa
approved these changes
Jan 27, 2025
parthmannan
pushed a commit
that referenced
this pull request
Jan 28, 2025
* add support for expert tensor parallelism Signed-off-by: gdeng <[email protected]> * remove function that's going to be deprecated Signed-off-by: gdeng <[email protected]> * format Signed-off-by: gdeng <[email protected]> * Apply isort and black reformatting Signed-off-by: gdengk <[email protected]> * add missing initilization Signed-off-by: gdeng <[email protected]> * fix unit test Signed-off-by: gdeng <[email protected]> --------- Signed-off-by: gdeng <[email protected]> Signed-off-by: gdengk <[email protected]> Co-authored-by: gdengk <[email protected]> Signed-off-by: Parth Mannan <[email protected]>
abhinavg4
pushed a commit
that referenced
this pull request
Jan 30, 2025
* add support for expert tensor parallelism Signed-off-by: gdeng <[email protected]> * remove function that's going to be deprecated Signed-off-by: gdeng <[email protected]> * format Signed-off-by: gdeng <[email protected]> * Apply isort and black reformatting Signed-off-by: gdengk <[email protected]> * add missing initilization Signed-off-by: gdeng <[email protected]> * fix unit test Signed-off-by: gdeng <[email protected]> --------- Signed-off-by: gdeng <[email protected]> Signed-off-by: gdengk <[email protected]> Co-authored-by: gdengk <[email protected]> Signed-off-by: Abhinav Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
add expert tensor parallelism support for NeMo2.0 MoE and substitute get_data_modulo_expert_parallel_group with get_expert_data_parallel_group since the former one is going to be deprecated.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information