Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Fix AttentionParams comparison logic #1397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

[PyTorch] Fix AttentionParams comparison logic #1397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions transformer_engine/pytorch/attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,24 @@ class AttentionParams:
fp8: bool = False
fp8_meta: Union[Dict[str, Any], None] = None

def __eq__(self, other):
"""
Overwrite dataclass.__eq__ so that only fp8_meta["recipe"] is compared,
since all other entries of fp8_meta are unused in get_attention_backend.
"""
if not isinstance(other, self.__class__):
return NotImplemented
for field in fields(self):
fname = field.name
sf = getattr(self, fname)
of = getattr(other, fname)
if fname != "fp8_meta":
if sf != of:
return False
elif sf["recipe"] != of["recipe"]:
return False
return True


_alibi_cache = {
"_num_heads": None,
Expand Down
Loading