Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit suggestions #979

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[pre-commit.ci] pre-commit suggestions #979

wants to merge 2 commits into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jul 2, 2024 •
edited
Loading

timmoon10
timmoon10 requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should verify that this doesn't cause significant changes. I think it's better to avoid merge conflicts, even if our clang-format version is years out-of-date.

ksivaman
ksivaman requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@ksivaman ksivaman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this PR in an open+blocked state and only make these changes after manual testing as and when needed. Unfortunately there is no option in precommit.ci to disable the config update altogether.

@timmoon10 timmoon10 added the wontfix This will not be worked on label Jul 8, 2024
@timmoon10 timmoon10 marked this pull request as draft July 8, 2024 21:24
@pre-commit-ci
[pre-commit.ci] pre-commit suggestions
b682881 
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/psf/black: 24.4.2 → 24.10.0](psf/black@24.4.2...24.10.0)
- [github.com/pre-commit/mirrors-clang-format: v18.1.6 → v19.1.6](pre-commit/mirrors-clang-format@v18.1.6...v19.1.6)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from a2a6b86 to b682881 Compare January 7, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksivaman ksivaman ksivaman requested changes

@timmoon10 timmoon10 timmoon10 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmoon10 @ksivaman