implement `<cuda/std/numbers>` #3355

davebayer · 2025-01-11T10:08:39Z

This PR implements <numbers> from C++20 (P0631R8) and makes it available back to C++14 (no extra effort was required).

copy-pr-bot · 2025-01-11T10:08:43Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

libcudacxx/include/cuda/std/numbers

miscco · 2025-01-13T08:44:13Z

libcudacxx/include/cuda/std/numbers

+template <class _Tp>
+_CCCL_GLOBAL_CONSTANT _Tp e_v = __e<_Tp>::value;


I believe we should rather just require _CCCL_NO_VARIABLE_TEMPLATES for the whole thing.

A user cannot instantiate the structs anyhow, so it does not really add that much value but forces us to always instantiate a type when we would only need a variable.

We should rather just specialize the variable templates with the values and have the generic case be assigned from _Ill_formed<_Tp>. In that case we are static_asserting anyhow so paying that is fine

The reason I did not wrap everything by _CCCL_NO_VARIABLE_TEMPLATES is that I was not sure if there would be a need for these constants internally for C++11 (I know it's already deprecated), because I think it can be quite useful.

We can always add the more expensive method when we need it but we should use the efficient way if we can

libcudacxx/test/libcudacxx/std/numerics/numbers/illformed.fail.cpp

miscco · 2025-01-13T09:38:09Z

/ok to test

github-actions · 2025-01-13T11:14:12Z

🟨 CI finished in 1h 34m: Pass: 95%/144 | Total: 1d 10h | Avg: 14m 14s | Max: 1h 15m | Hits: 140%/12680

🟨 libcudacxx: Pass: 86%/46 | Total: 9h 33m | Avg: 12m 28s | Max: 1h 01m

🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  86%/44  | Total:  9h 27m | Avg: 12m 53s | Max:  1h 01m
  🟩 arm64              Pass: 100%/2   | Total:  6m 48s | Avg:  3m 24s | Max:  3m 39s
🔍 cudacxx_family: nvcc 🔍
  🟩 ClangCUDA          Pass: 100%/4   | Total:  1h 07m | Avg: 16m 51s | Max: 22m 15s
  🔍 nvcc               Pass:  85%/42  | Total:  8h 26m | Avg: 12m 03s | Max:  1h 01m
🟨 ctk
  🟨 12.0               Pass:  75%/8   | Total: 46m 50s | Avg:  5m 51s | Max: 13m 55s
  🟩 12.5               Pass: 100%/2   | Total:  1h 07m | Avg: 33m 33s | Max: 34m 56s
  🟨 12.6               Pass:  88%/36  | Total:  7h 39m | Avg: 12m 46s | Max:  1h 01m
🟨 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total:  1h 07m | Avg: 16m 51s | Max: 22m 15s
  🟨 nvcc12.0           Pass:  75%/8   | Total: 46m 50s | Avg:  5m 51s | Max: 13m 55s
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 07m | Avg: 33m 33s | Max: 34m 56s
  🟨 nvcc12.6           Pass:  87%/32  | Total:  6h 32m | Avg: 12m 15s | Max:  1h 01m
🟨 cxx
  🟩 Clang14            Pass: 100%/6   | Total: 23m 33s | Avg:  3m 55s | Max:  4m 30s
  🟩 Clang15            Pass: 100%/1   | Total:  4m 24s | Avg:  4m 24s | Max:  4m 24s
  🟩 Clang16            Pass: 100%/1   | Total:  4m 29s | Avg:  4m 29s | Max:  4m 29s
  🟩 Clang17            Pass: 100%/1   | Total:  4m 23s | Avg:  4m 23s | Max:  4m 23s
  🟩 Clang18            Pass: 100%/8   | Total:  2h 16m | Avg: 17m 00s | Max: 56m 11s
  🟩 GCC7               Pass: 100%/5   | Total: 16m 51s | Avg:  3m 22s | Max:  3m 41s
  🟩 GCC8               Pass: 100%/1   | Total:  3m 48s | Avg:  3m 48s | Max:  3m 48s
  🟩 GCC9               Pass: 100%/3   | Total: 10m 04s | Avg:  3m 21s | Max:  4m 01s
  🟩 GCC10              Pass: 100%/1   | Total:  3m 45s | Avg:  3m 45s | Max:  3m 45s
  🟩 GCC11              Pass: 100%/1   | Total:  3m 49s | Avg:  3m 49s | Max:  3m 49s
  🟩 GCC12              Pass: 100%/1   | Total:  3m 46s | Avg:  3m 46s | Max:  3m 46s
  🟨 GCC13              Pass:  90%/10  | Total:  3h 40m | Avg: 22m 03s | Max:  1h 01m
  🟥 MSVC14.29          Pass:   0%/3   | Total: 42m 20s | Avg: 14m 06s | Max: 14m 47s
  🟥 MSVC14.39          Pass:   0%/2   | Total: 28m 57s | Avg: 14m 28s | Max: 14m 59s
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 07m | Avg: 33m 33s | Max: 34m 56s
🟨 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  2h 52m | Avg: 10m 10s | Max: 56m 11s
  🟨 GCC                Pass:  95%/22  | Total:  4h 22m | Avg: 11m 56s | Max:  1h 01m
  🟥 MSVC               Pass:   0%/5   | Total:  1h 11m | Avg: 14m 15s | Max: 14m 59s
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 07m | Avg: 33m 33s | Max: 34m 56s
🟨 jobs
  🟨 Build              Pass:  87%/39  | Total:  5h 11m | Avg:  7m 59s | Max: 34m 56s
  🟨 NVRTC              Pass:  75%/4   | Total:  2h 26m | Avg: 36m 41s | Max:  1h 01m
  🟩 Test               Pass: 100%/2   | Total:  1h 53m | Avg: 56m 38s | Max: 57m 06s
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  2m 02s | Avg:  2m 02s | Max:  2m 02s
🟨 std
  🟩 11                 Pass: 100%/6   | Total: 44m 27s | Avg:  7m 24s | Max: 28m 38s
  🟨 14                 Pass:  50%/4   | Total: 44m 41s | Avg: 11m 10s | Max: 22m 54s
  🟨 17                 Pass:  78%/14  | Total:  2h 37m | Avg: 11m 12s | Max: 33m 54s
  🟨 20                 Pass:  95%/21  | Total:  5h 25m | Avg: 15m 30s | Max:  1h 01m
🟨 gpu
  🟨 v100               Pass:  86%/46  | Total:  9h 33m | Avg: 12m 28s | Max:  1h 01m
🟩 sm
  🟩 90                 Pass: 100%/1   | Total: 13m 27s | Avg: 13m 27s | Max: 13m 27s
  🟩 90a                Pass: 100%/2   | Total: 17m 32s | Avg:  8m 46s | Max: 13m 44s

🟩 cub: Pass: 100%/38 | Total: 12h 19m | Avg: 19m 27s | Max: 1h 15m | Hits: 33%/3108

🟩 cpu
  🟩 amd64              Pass: 100%/36  | Total: 12h 10m | Avg: 20m 16s | Max:  1h 15m | Hits:  33%/3108  
  🟩 arm64              Pass: 100%/2   | Total:  9m 30s | Avg:  4m 45s | Max:  4m 50s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 27m | Avg: 17m 26s | Max:  1h 06m | Hits:  33%/777   
  🟩 12.5               Pass: 100%/2   | Total:  2h 21m | Avg:  1h 10m | Max:  1h 10m
  🟩 12.6               Pass: 100%/31  | Total:  8h 31m | Avg: 16m 29s | Max:  1h 15m | Hits:  33%/2331  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  8m 50s | Avg:  4m 25s | Max:  4m 36s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 27m | Avg: 17m 26s | Max:  1h 06m | Hits:  33%/777   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 21m | Avg:  1h 10m | Max:  1h 10m
  🟩 nvcc12.6           Pass: 100%/29  | Total:  8h 22m | Avg: 17m 19s | Max:  1h 15m | Hits:  33%/2331  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  8m 50s | Avg:  4m 25s | Max:  4m 36s
  🟩 nvcc               Pass: 100%/36  | Total: 12h 10m | Avg: 20m 17s | Max:  1h 15m | Hits:  33%/3108  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 20m 44s | Avg:  5m 11s | Max:  5m 33s
  🟩 Clang15            Pass: 100%/1   | Total:  5m 24s | Avg:  5m 24s | Max:  5m 24s
  🟩 Clang16            Pass: 100%/1   | Total:  5m 41s | Avg:  5m 41s | Max:  5m 41s
  🟩 Clang17            Pass: 100%/1   | Total:  5m 43s | Avg:  5m 43s | Max:  5m 43s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 15m | Avg: 10m 46s | Max: 28m 27s
  🟩 GCC7               Pass: 100%/2   | Total: 11m 08s | Avg:  5m 34s | Max:  5m 46s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 36s | Avg:  5m 36s | Max:  5m 36s
  🟩 GCC9               Pass: 100%/2   | Total: 10m 31s | Avg:  5m 15s | Max:  5m 28s
  🟩 GCC10              Pass: 100%/1   | Total:  5m 27s | Avg:  5m 27s | Max:  5m 27s
  🟩 GCC11              Pass: 100%/1   | Total:  5m 43s | Avg:  5m 43s | Max:  5m 43s
  🟩 GCC12              Pass: 100%/3   | Total: 26m 13s | Avg:  8m 44s | Max: 16m 04s
  🟩 GCC13              Pass: 100%/8   | Total:  2h 25m | Avg: 18m 12s | Max:  1h 11m
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 13m | Avg:  1h 06m | Max:  1h 07m | Hits:  33%/1554  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  2h 21m | Avg:  1h 10m | Max:  1h 15m | Hits:  33%/1554  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 21m | Avg:  1h 10m | Max:  1h 10m
🟩 cxx_family
  🟩 Clang              Pass: 100%/14  | Total:  1h 52m | Avg:  8m 03s | Max: 28m 27s
  🟩 GCC                Pass: 100%/18  | Total:  3h 30m | Avg: 11m 41s | Max:  1h 11m
  🟩 MSVC               Pass: 100%/4   | Total:  4h 35m | Avg:  1h 08m | Max:  1h 15m | Hits:  33%/3108  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 21m | Avg:  1h 10m | Max:  1h 10m
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 20m 11s | Avg: 10m 05s | Max: 16m 04s
  🟩 v100               Pass: 100%/36  | Total: 11h 59m | Avg: 19m 58s | Max:  1h 15m | Hits:  33%/3108  
🟩 jobs
  🟩 Build              Pass: 100%/31  | Total:  9h 07m | Avg: 17m 39s | Max:  1h 15m | Hits:  33%/3108  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 17m 46s | Avg: 17m 46s | Max: 17m 46s
  🟩 GraphCapture       Pass: 100%/1   | Total: 15m 37s | Avg: 15m 37s | Max: 15m 37s
  🟩 HostLaunch         Pass: 100%/3   | Total: 59m 08s | Avg: 19m 42s | Max: 22m 48s
  🟩 TestGPU            Pass: 100%/2   | Total:  1h 39m | Avg: 49m 47s | Max:  1h 11m
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 20m 11s | Avg: 10m 05s | Max: 16m 04s
  🟩 90a                Pass: 100%/1   | Total:  4m 25s | Avg:  4m 25s | Max:  4m 25s
🟩 std
  🟩 17                 Pass: 100%/14  | Total:  5h 23m | Avg: 23m 08s | Max:  1h 10m | Hits:  33%/2331  
  🟩 20                 Pass: 100%/24  | Total:  6h 55m | Avg: 17m 19s | Max:  1h 15m | Hits:  33%/777

🟩 thrust: Pass: 100%/37 | Total: 9h 30m | Avg: 15m 25s | Max: 1h 10m | Hits: 177%/9260

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 21m 33s | Avg: 10m 46s | Max: 15m 53s
🟩 cpu
  🟩 amd64              Pass: 100%/35  | Total:  9h 21m | Avg: 16m 02s | Max:  1h 10m | Hits: 177%/9260  
  🟩 arm64              Pass: 100%/2   | Total:  9m 34s | Avg:  4m 47s | Max:  5m 01s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 09m | Avg: 13m 59s | Max: 49m 24s | Hits: 130%/1852  
  🟩 12.5               Pass: 100%/2   | Total:  2h 19m | Avg:  1h 09m | Max:  1h 10m
  🟩 12.6               Pass: 100%/30  | Total:  6h 01m | Avg: 12m 03s | Max: 52m 26s | Hits: 189%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  5m 20s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 09m | Avg: 13m 59s | Max: 49m 24s | Hits: 130%/1852  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 19m | Avg:  1h 09m | Max:  1h 10m
  🟩 nvcc12.6           Pass: 100%/28  | Total:  5h 51m | Avg: 12m 32s | Max: 52m 26s | Hits: 189%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 37s | Avg:  5m 18s | Max:  5m 20s
  🟩 nvcc               Pass: 100%/35  | Total:  9h 20m | Avg: 16m 00s | Max:  1h 10m | Hits: 177%/9260  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 31s | Avg:  5m 22s | Max:  5m 50s
  🟩 Clang15            Pass: 100%/1   | Total:  5m 58s | Avg:  5m 58s | Max:  5m 58s
  🟩 Clang16            Pass: 100%/1   | Total:  5m 47s | Avg:  5m 47s | Max:  5m 47s
  🟩 Clang17            Pass: 100%/1   | Total:  5m 19s | Avg:  5m 19s | Max:  5m 19s
  🟩 Clang18            Pass: 100%/7   | Total: 44m 55s | Avg:  6m 25s | Max: 10m 38s
  🟩 GCC7               Pass: 100%/2   | Total: 10m 04s | Avg:  5m 02s | Max:  5m 07s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 28s | Avg:  5m 28s | Max:  5m 28s
  🟩 GCC9               Pass: 100%/2   | Total: 11m 27s | Avg:  5m 43s | Max:  5m 57s
  🟩 GCC10              Pass: 100%/1   | Total:  5m 54s | Avg:  5m 54s | Max:  5m 54s
  🟩 GCC11              Pass: 100%/1   | Total:  5m 34s | Avg:  5m 34s | Max:  5m 34s
  🟩 GCC12              Pass: 100%/1   | Total:  6m 08s | Avg:  6m 08s | Max:  6m 08s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 04m | Avg:  8m 03s | Max: 15m 53s
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 39m | Avg: 49m 57s | Max: 50m 31s | Hits: 130%/3704  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 19m | Avg: 46m 26s | Max: 52m 26s | Hits: 208%/5556  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 19m | Avg:  1h 09m | Max:  1h 10m
🟩 cxx_family
  🟩 Clang              Pass: 100%/14  | Total:  1h 23m | Avg:  5m 57s | Max: 10m 38s
  🟩 GCC                Pass: 100%/16  | Total:  1h 49m | Avg:  6m 48s | Max: 15m 53s
  🟩 MSVC               Pass: 100%/5   | Total:  3h 59m | Avg: 47m 51s | Max: 52m 26s | Hits: 177%/9260  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 19m | Avg:  1h 09m | Max:  1h 10m
🟩 gpu
  🟩 v100               Pass: 100%/37  | Total:  9h 30m | Avg: 15m 25s | Max:  1h 10m | Hits: 177%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/31  | Total:  7h 57m | Avg: 15m 23s | Max:  1h 10m | Hits: 130%/7408  
  🟩 TestCPU            Pass: 100%/3   | Total: 53m 33s | Avg: 17m 51s | Max: 37m 45s | Hits: 365%/1852  
  🟩 TestGPU            Pass: 100%/3   | Total: 40m 03s | Avg: 13m 21s | Max: 15m 53s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 18s | Avg:  4m 18s | Max:  4m 18s
🟩 std
  🟩 17                 Pass: 100%/14  | Total:  4h 32m | Avg: 19m 29s | Max:  1h 08m | Hits: 130%/5556  
  🟩 20                 Pass: 100%/21  | Total:  4h 36m | Avg: 13m 10s | Max:  1h 10m | Hits: 247%/3704

🟩 cudax: Pass: 100%/20 | Total: 2h 12m | Avg: 6m 36s | Max: 28m 48s | Hits: 96%/312

🟩 cpu
  🟩 amd64              Pass: 100%/16  | Total:  2h 00m | Avg:  7m 32s | Max: 28m 48s | Hits:  96%/312   
  🟩 arm64              Pass: 100%/4   | Total: 11m 23s | Avg:  2m 50s | Max:  3m 14s
🟩 ctk
  🟩 12.0               Pass: 100%/1   | Total: 12m 27s | Avg: 12m 27s | Max: 12m 27s | Hits:  96%/156   
  🟩 12.5               Pass: 100%/2   | Total: 18m 07s | Avg:  9m 03s | Max:  9m 31s
  🟩 12.6               Pass: 100%/17  | Total:  1h 41m | Avg:  5m 58s | Max: 28m 48s | Hits:  96%/156   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/1   | Total: 12m 27s | Avg: 12m 27s | Max: 12m 27s | Hits:  96%/156   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 18m 07s | Avg:  9m 03s | Max:  9m 31s
  🟩 nvcc12.6           Pass: 100%/17  | Total:  1h 41m | Avg:  5m 58s | Max: 28m 48s | Hits:  96%/156   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/20  | Total:  2h 12m | Avg:  6m 36s | Max: 28m 48s | Hits:  96%/312   
🟩 cxx
  🟩 Clang14            Pass: 100%/1   | Total:  3m 03s | Avg:  3m 03s | Max:  3m 03s
  🟩 Clang15            Pass: 100%/1   | Total:  3m 12s | Avg:  3m 12s | Max:  3m 12s
  🟩 Clang16            Pass: 100%/1   | Total:  3m 19s | Avg:  3m 19s | Max:  3m 19s
  🟩 Clang17            Pass: 100%/1   | Total:  3m 25s | Avg:  3m 25s | Max:  3m 25s
  🟩 Clang18            Pass: 100%/4   | Total: 26m 50s | Avg:  6m 42s | Max: 17m 07s
  🟩 GCC10              Pass: 100%/1   | Total:  3m 36s | Avg:  3m 36s | Max:  3m 36s
  🟩 GCC11              Pass: 100%/1   | Total:  2m 56s | Avg:  2m 56s | Max:  2m 56s
  🟩 GCC12              Pass: 100%/2   | Total: 32m 10s | Avg: 16m 05s | Max: 28m 48s
  🟩 GCC13              Pass: 100%/4   | Total: 10m 58s | Avg:  2m 44s | Max:  2m 55s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 12m 27s | Avg: 12m 27s | Max: 12m 27s | Hits:  96%/156   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 11m 59s | Avg: 11m 59s | Max: 11m 59s | Hits:  96%/156   
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 18m 07s | Avg:  9m 03s | Max:  9m 31s
🟩 cxx_family
  🟩 Clang              Pass: 100%/8   | Total: 39m 49s | Avg:  4m 58s | Max: 17m 07s
  🟩 GCC                Pass: 100%/8   | Total: 49m 40s | Avg:  6m 12s | Max: 28m 48s
  🟩 MSVC               Pass: 100%/2   | Total: 24m 26s | Avg: 12m 13s | Max: 12m 27s | Hits:  96%/312   
  🟩 NVHPC              Pass: 100%/2   | Total: 18m 07s | Avg:  9m 03s | Max:  9m 31s
🟩 gpu
  🟩 v100               Pass: 100%/20  | Total:  2h 12m | Avg:  6m 36s | Max: 28m 48s | Hits:  96%/312   
🟩 jobs
  🟩 Build              Pass: 100%/18  | Total:  1h 26m | Avg:  4m 47s | Max: 12m 27s | Hits:  96%/312   
  🟩 Test               Pass: 100%/2   | Total: 45m 55s | Avg: 22m 57s | Max: 28m 48s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  2m 55s | Avg:  2m 55s | Max:  2m 55s
  🟩 90a                Pass: 100%/1   | Total:  2m 55s | Avg:  2m 55s | Max:  2m 55s
🟩 std
  🟩 17                 Pass: 100%/4   | Total: 17m 06s | Avg:  4m 16s | Max:  8m 36s
  🟩 20                 Pass: 100%/16  | Total:  1h 54m | Avg:  7m 11s | Max: 28m 48s | Hits:  96%/312

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 52s | Avg: 4m 56s | Max: 7m 48s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  9m 52s | Avg:  4m 56s | Max:  7m 48s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  9m 52s | Avg:  4m 56s | Max:  7m 48s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  9m 52s | Avg:  4m 56s | Max:  7m 48s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  9m 52s | Avg:  4m 56s | Max:  7m 48s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  9m 52s | Avg:  4m 56s | Max:  7m 48s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  9m 52s | Avg:  4m 56s | Max:  7m 48s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total:  9m 52s | Avg:  4m 56s | Max:  7m 48s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 04s | Avg:  2m 04s | Max:  2m 04s
  🟩 Test               Pass: 100%/1   | Total:  7m 48s | Avg:  7m 48s | Max:  7m 48s

🟩 python: Pass: 100%/1 | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
+/-	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
+/-	libcu++
+/-	CUB
+/-	Thrust
+/-	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 144)

#	Runner
98	`linux-amd64-cpu16`
19	`linux-amd64-gpu-v100-latest-1`
16	`windows-amd64-cpu16`
10	`linux-arm64-cpu16`
1	`linux-amd64-gpu-h100-latest-1-testing`

implement <numbers>

60485cc

davebayer requested review from a team as code owners January 11, 2025 10:08

davebayer requested a review from griwes January 11, 2025 10:08

davebayer requested a review from miscco January 11, 2025 10:08

davebayer changed the title ~~implement <numbers>~~ implement <cuda/std/numbers> Jan 11, 2025

davebayer added 2 commits January 11, 2025 11:44

move test to correct place

13546c0

add support for extended floating point types

22afb87

miscco requested changes Jan 13, 2025

View reviewed changes

miscco reviewed Jan 13, 2025

View reviewed changes

libcudacxx/test/libcudacxx/std/numerics/numbers/illformed.fail.cpp Outdated Show resolved Hide resolved

fix review

f211c2f

miscco approved these changes Jan 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement `<cuda/std/numbers>` #3355

implement `<cuda/std/numbers>` #3355

davebayer commented Jan 11, 2025 •

edited

Loading

copy-pr-bot bot commented Jan 11, 2025

miscco Jan 13, 2025

davebayer Jan 13, 2025

miscco Jan 13, 2025

miscco commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

🟨 libcudacxx: Pass: 86%/46 | Total: 9h 33m | Avg: 12m 28s | Max: 1h 01m

🟩 cub: Pass: 100%/38 | Total: 12h 19m | Avg: 19m 27s | Max: 1h 15m | Hits: 33%/3108

🟩 thrust: Pass: 100%/37 | Total: 9h 30m | Avg: 15m 25s | Max: 1h 10m | Hits: 177%/9260

🟩 cudax: Pass: 100%/20 | Total: 2h 12m | Avg: 6m 36s | Max: 28m 48s | Hits: 96%/312

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 52s | Avg: 4m 56s | Max: 7m 48s

🟩 python: Pass: 100%/1 | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 144)

		template <class _Tp>
		_CCCL_GLOBAL_CONSTANT _Tp e_v = __e<_Tp>::value;

implement <cuda/std/numbers> #3355

Are you sure you want to change the base?

implement <cuda/std/numbers> #3355

Conversation

davebayer commented Jan 11, 2025 • edited Loading

copy-pr-bot bot commented Jan 11, 2025

miscco Jan 13, 2025

Choose a reason for hiding this comment

davebayer Jan 13, 2025

Choose a reason for hiding this comment

miscco Jan 13, 2025

Choose a reason for hiding this comment

miscco commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

🟨 libcudacxx: Pass: 86%/46 | Total: 9h 33m | Avg: 12m 28s | Max: 1h 01m

🟩 cub: Pass: 100%/38 | Total: 12h 19m | Avg: 19m 27s | Max: 1h 15m | Hits: 33%/3108

🟩 thrust: Pass: 100%/37 | Total: 9h 30m | Avg: 15m 25s | Max: 1h 10m | Hits: 177%/9260

🟩 cudax: Pass: 100%/20 | Total: 2h 12m | Avg: 6m 36s | Max: 28m 48s | Hits: 96%/312

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 52s | Avg: 4m 56s | Max: 7m 48s

🟩 python: Pass: 100%/1 | Total: 23m 50s | Avg: 23m 50s | Max: 23m 50s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 144)

implement `<cuda/std/numbers>` #3355

implement `<cuda/std/numbers>` #3355

davebayer commented Jan 11, 2025 •

edited

Loading