Fix for sparse GID tables (not starting at one) #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is for supporting sparse GID tables. Especially in Kubernetes environments, a pod can end up with a GID table that does not start at "1". This arises when there is another pod on the host that has assigned an IP address to the NIC (usually when they are exposed through MACVLAN to multiple pods). An example: ``` $ show_gids DEV PORT INDEX GID IPv4 VER DEV --- ---- ----- --- ------------ --- --- mlx5_0 1 6 0000:0000:0000:0000:0000:ffff:0b00:0401 11.0.4.1 v1 net1 mlx5_0 1 7 0000:0000:0000:0000:0000:ffff:0b00:0401 11.0.4.1 v2 net1 mlx5_0 1 8 fe80:0000:0000:0000:e4ea:71ff:feb9:4970 v1 net1 mlx5_0 1 9 fe80:0000:0000:0000:e4ea:71ff:feb9:4970 v2 net1 ``` This patch fixes the existing code which has two problems for dealing with this: 1) The GID index loop can terminate prematurely because of an error being thrown in searching for the GID by testing an invalid GID 2) A non-valid GID could be selected (by just comparing address families), and then on subsequent tests, the ROCE call would fail, resulting in a valid GID being skipped.
|
Hi @jlamanna, this was already reported here: #1573 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is for supporting sparse GID tables. Especially in Kubernetes environments, a pod can end up with a GID table that does not start at "1". This arises when there is another pod on the host that has assigned an IP address to the NIC (usually when they are exposed through MACVLAN to multiple pods).
An example:
This patch fixes the existing code which has two problems for dealing with this:
being thrown in searching for the GID by testing an invalid GID
families), and then on subsequent tests, the ROCE call would fail,
resulting in a valid GID being skipped.