-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyper log log plus plus(HLL++) #2522
Open
res-life
wants to merge
33
commits into
NVIDIA:branch-25.02
Choose a base branch
from
res-life:hll
base: branch-25.02
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,772
−1
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
03c0f5a
Add HLL++ evaluation function
df8b223
Update function comments
2daca3f
Fix
3afdfde
Use exec_policy_nosync instead of exec_policy
956af39
Format code; Remove a useless file
8aaf0f6
Merge branch 'branch-25.02' into hll
5bfb544
Use UDF
f8c6a02
Use UDF
208d67e
Use UDF
e29d5a1
Address comments
9f7ec44
Merge branch 'branch-25.02' into hll
3c70a30
Merge branch 'branch-25.02' into hll
3e22512
Fix compile error
aa7ca68
Handle null inputs: must ignore the null input values
f0970c0
Rename refactor: Correct spelling errors
2e74412
Update copyright for new year 2025
7fe4a39
Use get_current_device_resource_ref
b7058a7
Fix comments
78cc207
Fix comments
4d202f4
Merge branch 'branch-25.02' into hll
2281d69
Merge branch 'branch-25.02' into hll
d045020
Close host UDF instance using JNI
a7cef89
Address comments
278d8d9
Fix compile error
86832ae
Address comments
b331db9
Address comments
7b929b4
Address comments
6fcf7e0
Address comments
024da64
Change make device uvector from async to sync
c9f4bfb
Add test case
b678c17
Format and Copyright
cbc3d12
Update according to cuDF UDF instance management change
ff48be6
Merge branch 'branch-25.02' into hll
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use exec_policy_nosync instead of exec_policy
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/home/chongg/code/spark-rapids-jni/target/jni/cmake-build/compile_commands.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need such all-valid null mask? How about
cudf::mask_state::UNALLOCATED
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Spark behavior, for
approx_count_distinct(null)
returns 0.So the values in result column are always non-null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant, if all rows are valid, we don't need to allocate a null mask.
BTW, we need to pass
mr
to the returning column (but do not pass it to the intermediate vector/column).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.