Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose max stack depth in hash function to plugin #2680

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Expose max stack depth in hash function to plugin #2680

merged 8 commits into from
Dec 12, 2024

Conversation

ustcfy
Copy link
Collaborator

@ustcfy ustcfy commented Dec 11, 2024 •
edited by res-life
Loading

Closes #2681

This PR includes the following changes:

  1. Moved the definition of MAX_STACK_DEPTH from the specific hash function to hash.hpp.
  2. Exposed the value of this parameter to plugin.

@ustcfy ustcfy self-assigned this Dec 11, 2024
@ustcfy
Format C++ code
2e545ba 
Signed-off-by: Yan Feng <[email protected]>
@ustcfy ustcfy linked an issue Dec 11, 2024 that may be closed by this pull request
[FEA]Expose max nesting depth in hash function to plugin #2681
Closed
@firestarman
Copy link
Collaborator

build

firestarman
firestarman previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@firestarman firestarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ustcfy ustcfy requested review from ttnghia and res-life December 11, 2024 09:37
@res-life
Copy link
Collaborator

res-life commented Dec 11, 2024 •
edited
Loading

MAX_NESTED_DEPTH now is not reflecting the code because we have some performance improvement to save stack depth.
Maybe: change MAX_NESTED_DEPTH to MAX_STACK_DEPTH.

e.g.:
For xxhash64, for list(list(list(int))) it only uses max stack length < 4.

@pxLi
Copy link
Collaborator

pxLi commented Dec 12, 2024

build

@ustcfy ustcfy merged commit 32834e6 into NVIDIA:branch-25.02 Dec 12, 2024
4 checks passed
@ustcfy ustcfy deleted the feature/expose-max-nesting-depth branch December 12, 2024 07:56
@res-life res-life changed the title Expose max nesting depth in hash function to plugin Expose max stack depth in hash function to plugin Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@res-life res-life res-life approved these changes

@ttnghia ttnghia ttnghia approved these changes

@firestarman firestarman firestarman left review comments

Assignees

@ustcfy ustcfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]Expose max nesting depth in hash function to plugin
5 participants
@ustcfy @firestarman @res-life @pxLi @ttnghia