Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of small fixes for Scav. #4816

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Couple of small fixes for Scav. #4816

merged 2 commits into from
Jan 26, 2025

Conversation

MistakeNot4892
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label Jan 25, 2025
out-of-phaze
out-of-phaze approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@out-of-phaze out-of-phaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should maybe make the implants enumerate available emotes at some point so it can't let you pick one you're not actually able to do, maybe change that on dev?

out-of-phaze
out-of-phaze approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@out-of-phaze out-of-phaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shockingly the material stacker thing is the only match for the regex \\(?:[Aa]|[Tt]he) \[([^\]]+)\][^["]*\\(?:[Aa]|[Tt]he) \[\1\], pretty neat?

@comma comma merged commit 9a8da21 into NebulaSS13:staging Jan 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@out-of-phaze out-of-phaze out-of-phaze approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MistakeNot4892 @out-of-phaze @comma