Collapsing organ damage procs down into take_damage(). #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
the
work in progress
MistakeNot4892
force-pushed
the
rework/damage
branch
from
1a67d58 to
a1d1bd9
Compare
|
Organ damage vars need to get merged with item health at some point but I have not done that in this PR. |
out-of-phaze
previously approved these changes
Feb 1, 2025
out-of-phaze
dismissed
their stale review
was not meant to be an approval, just a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Merges
take_internal_damage(),take_general_damage()andtake_external_damage()intotake_damage().Why and what will this PR improve
Cleaner code.
Authorship
Myself.
Changelog
Nothing player-facing.