cleanups

NeoApplications · Jul 12, 2024 · 7d40355 · 7d40355
1 parent d05c967
commit 7d40355
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 53 deletions.
diff --git a/FAQ.md b/FAQ.md
@@ -561,7 +561,7 @@ Note: If you're using banking apps, TAN generators etc., the [app may use Androi
 
 More detailed articles about - how to properly backup your device - would be great, but it comes with lots of caveats due to variety of devices and versions. So it is a challenge to keep/word this as general as possible, as well as keeping it up to date (which is also true for this FAQ itself). If you have the knowledge and time to prepare such guidance for anyone, who's really interested in doing it right, we are happy about any participation.
 
-You probaly want to look into [app-restore-experiences.txt](app-restore-experiences.txt), where we started to document (loosely for now), how apps react on the restore. You should get a picture what to expect and how imperfect a restore will be in general. The times to get a complete restore with on click are definitely gone.
+You probably want to look into [app-restore-experiences.txt](app-restore-experiences.txt), where we started to loosly document, how apps react on the restore. You should get a picture what to expect and how imperfect a restore will be in general. The times to get a complete restore with one click are definitely gone.
 
 ## Why do I have to login/register to app x y z again after restore?
 

diff --git a/app/src/main/java/com/machiav3lli/backup/OABX.kt b/app/src/main/java/com/machiav3lli/backup/OABX.kt
@@ -678,7 +678,7 @@ class OABX : Application() {
         //------------------------------------------------------------------------------------------ section
 
         fun beginLogSection(section: String) {
-            var count = 0
+            var count : Int
             synchronized(logSections) {
                 count = logSections.getValue(section)
                 logSections[section] = count + 1

diff --git a/app/src/main/java/com/machiav3lli/backup/dbs/entity/Backup.kt b/app/src/main/java/com/machiav3lli/backup/dbs/entity/Backup.kt
@@ -67,57 +67,6 @@ data class Backup @OptIn(ExperimentalSerializationApi::class) constructor(
     @ColumnInfo(defaultValue = "0")
     var persistent: Boolean = false,
 ) {
-    // TODO WECH
-    // TODO hg42
-    // it's unused (can there be any hidden references? e.g. dynamic?)
-    // seems to construct from android.content.pm.PackageInfo which is now capsulated in NB's PackageInfo
-    //constructor(
-    //    context: Context,
-    //    pi: PackageInfo,
-    //    backupDate: LocalDateTime,
-    //    hasApk: Boolean,
-    //    hasAppData: Boolean,
-    //    hasDevicesProtectedData: Boolean,
-    //    hasExternalData: Boolean,
-    //    hasObbData: Boolean,
-    //    hasMediaData: Boolean,
-    //    compressionType: String?,
-    //    cipherType: String?,
-    //    iv: ByteArray?,
-    //    cpuArch: String?,
-    //    size: Long,
-    //    persistent: Boolean = false,
-    //) : this(
-    //    backupVersionCode = BuildConfig.MAJOR * 1000 + BuildConfig.MINOR,
-    //    packageName = pi.packageName,
-    //    packageLabel = pi.applicationInfo.loadLabel(context.packageManager).toString(),
-    //    versionName = pi.versionName,
-    //    versionCode = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) pi.longVersionCode.toInt()
-    //    else pi.versionCode,
-    //    profileId = try {
-    //        File(pi.applicationInfo.dataDir).parentFile?.name?.toInt() ?: -1
-    //    } catch (e: NumberFormatException) {
-    //        -1 // Android System "App" points to /data/system
-    //    },
-    //    sourceDir = pi.applicationInfo.sourceDir,
-    //    splitSourceDirs = pi.applicationInfo.splitSourceDirs ?: arrayOf(),
-    //    isSystem = pi.applicationInfo.flags and ApplicationInfo.FLAG_SYSTEM == ApplicationInfo.FLAG_SYSTEM,
-    //    backupDate = backupDate,
-    //    hasApk = hasApk,
-    //    hasAppData = hasAppData,
-    //    hasDevicesProtectedData = hasDevicesProtectedData,
-    //    hasExternalData = hasExternalData,
-    //    hasObbData = hasObbData,
-    //    hasMediaData = hasMediaData,
-    //    compressionType = compressionType,
-    //    cipherType = cipherType,
-    //    iv = iv,
-    //    cpuArch = cpuArch,
-    //    permissions = pi.grantedPermissions.sorted(),
-    //    size = size,
-    //    persistent = persistent,
-    //)
-
     constructor(
         base: com.machiav3lli.backup.dbs.entity.PackageInfo,
         backupDate: LocalDateTime,