Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen AppleDouble checks for DragonflyBSD and OpenBSD #1841

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Jan 3, 2025

Applying the fix for macOS in #1829

@NJRoadfan
Copy link
Contributor

I just realized the changes made to fix the problem on macOS might cause problems with servers running both Samba and Netatalk. The vfs_fruit module use the exact same code to verify AppleDouble file headers. It would obviously fail a check in ad_entry_check_size() if the length of a PRIVDEV field is 4 vs. 8. As far as I know, OpenBSD and DragonflyBSD are supported Samba platforms. DragonflyBSD likely can't use vfs_fruit due to the lack of extended attribute support (is this still the case? Netatalk disables support) so likely wouldn't be a problem. Pinging @slowfranklin

@rdmark rdmark force-pushed the rdmark-bsd-loosen-ad branch from 0077940 to 2f7de1e Compare January 6, 2025 10:17
Copy link

sonarqubecloud bot commented Jan 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants