Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix producer metric reporting non-published version #458

Conversation

AlexandruGhergut
Copy link

@AlexandruGhergut AlexandruGhergut commented Mar 10, 2020

On each cycle that is run, a toVersion is computed.
The currentVersion metric of the producer is updated on each cycle to the above version. I find that misleading because when there is NO state change, there will be no new version published but the metric will still be updated, pointing to a non-existent version.

If I understood correctly, the producer's readState will be null when there is no state change so I removed the else branch in which the version update happened.

Also added a gradle setting to build the subprojects in parallel.

Use-case for this metric: we want to add an alert for consumers that are out-of-sync with the producer for a given amount of time. For that we look at the consumer's reported version and at the producer's version.

@AlexandruGhergut AlexandruGhergut force-pushed the fix_producer_currentVersion branch from 911a41e to 4fa1fc5 Compare March 10, 2020 13:20
@AlexandruGhergut
Copy link
Author

ping @toolbear @rpalcolea @akhaku

@AlexandruGhergut AlexandruGhergut changed the title Fix producer metrics reporting non-published version Fix producer metric reporting non-published version Mar 10, 2020
@AlexandruGhergut
Copy link
Author

Closing this in favor of #459

@AlexandruGhergut AlexandruGhergut deleted the fix_producer_currentVersion branch March 16, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant