-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pooled span dicitionary direct pointer #455
Draft
Scooletz
wants to merge
15
commits into
main
Choose a base branch
from
pooled-span-dicitionary-direct-pointer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipkakwani
reviewed
Jan 28, 2025
@@ -43,9 +50,15 @@ public PooledSpanDictionary(BufferPool pool, bool preserveOldValues = false) | |||
var pages = new Page[Root.PageCount]; | |||
for (var i = 0; i < Root.PageCount; i++) | |||
{ | |||
pages[i] = RentNewPage(true); | |||
pages[i] = RentNewPage(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting use of clearing the page in parallel. Makes me wonder if we could make a bulk/batch rent API as well, instead of sequentially renting a new page? Along the same lines, would exposing a batch Set API in PooledSpanDictionary
could also be useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
PooledSpanDictionary
to use pointers rather than relative addresses that need to then transformed before accessing. This unfortunately makes the address size twice as big (fromuint
tobyte*
). When theRoot
PageCount
is increased to make it big enough to keep the same number of buckets (128kb
for the root instead of the earlier64kb
), the new version wins.Benchmarks
Read_write_small
has been modified.Before pointer
After pointer and 2 times bigger Root