Update golangci-lint (#2057)

Makefile

@@ -83,7 +83,7 @@ install-mockgen:
 	go install go.uber.org/mock/mockgen@latest
 
 install-golangci-lint:
-	@which golangci-lint || go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59.1
+	@which golangci-lint || go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.1
 
 lint: install-golangci-lint
 	golangci-lint run

core/state.go

@@ -145,7 +145,7 @@ func (s *State) globalTrie(bucket db.Bucket, newTrie trie.NewTrieFunc) (*trie.Tr
 	})
 
 	// if some error other than "not found"
-	if err != nil && !errors.Is(db.ErrKeyNotFound, err) {
+	if err != nil && !errors.Is(err, db.ErrKeyNotFound) {
 		return nil, nil, err
 	}
 

db/pebble/transaction.go

@@ -94,6 +94,7 @@ func (t *Transaction) Get(key []byte, cb func([]byte) error) error {
 		return ErrDiscardedTransaction
 	}
 
+	// We need it evaluated immediately so the duration doesn't include the runtime of the user callback that we call below.
 	defer t.listener.OnIO(false, time.Since(start)) //nolint:govet
 	if err != nil {
 		if errors.Is(err, pebble.ErrNotFound) {

p2p/sync.go

@@ -64,7 +64,7 @@ func (s *syncService) start(ctx context.Context) {
 		var nextHeight int
 		if curHeight, err := s.blockchain.Height(); err == nil {
 			nextHeight = int(curHeight) + 1
-		} else if !errors.Is(db.ErrKeyNotFound, err) {
+		} else if !errors.Is(err, db.ErrKeyNotFound) {
 			s.log.Errorw("Failed to get current height", "err", err)
 		}