Bump golangci-lint and add linters (#2382)

* Update golangci-lint

* Remove unused nolint

* Add UseTesting linter

* Add nilnesserr linter

.golangci.yaml

@@ -110,6 +110,8 @@ linters:
     - tparallel
     - gci
     - exhaustruct
+    - usetesting
+    - nilnesserr
 
   # don't enable:
   # - asciicheck

Makefile

@@ -94,7 +94,7 @@ install-mockgen:
 	go install go.uber.org/mock/mockgen@latest
 
 install-golangci-lint:
-	@which golangci-lint || go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.62.2
+	@which golangci-lint || go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.63.4
 
 lint: install-golangci-lint ## Run linter
 	golangci-lint run

vm/vm.go

@@ -341,7 +341,7 @@ func (v *vm) Execute(txns []core.Transaction, declaredClasses []core.Class, paid
 	return context.actualFees, context.daGas, traces, context.executionSteps, nil
 }
 
-func marshalTxnsAndDeclaredClasses(txns []core.Transaction, declaredClasses []core.Class) (json.RawMessage, json.RawMessage, error) { //nolint:lll
+func marshalTxnsAndDeclaredClasses(txns []core.Transaction, declaredClasses []core.Class) (json.RawMessage, json.RawMessage, error) {
 	txnJSONs := make([]json.RawMessage, 0, len(txns))
 	for _, txn := range txns {
 		txnJSON, err := marshalTxn(txn)

vm/vm_test.go

@@ -224,7 +224,7 @@ func TestSetVersionedConstants(t *testing.T) {
 		assert.NoError(t, err)
 	})
 	t.Run("not valid json", func(t *testing.T) {
-		fd, err := os.CreateTemp("", "versioned_constants_test*")
+		fd, err := os.CreateTemp(t.TempDir(), "versioned_constants_test*")
 		require.NoError(t, err)
 		defer os.Remove(fd.Name())