Change TraceTransaction error code on txn hash not found case

NethermindEth · Nov 28, 2023 · 4e0b623 · 4e0b623
1 parent fff569c
commit 4e0b623
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/rpc/handlers.go b/rpc/handlers.go
@@ -1340,13 +1340,17 @@ func (h *Handler) TraceTransaction(ctx context.Context, hash felt.Felt) (json.Ra
 // It follows the specification defined here:
 // https://github.com/starkware-libs/starknet-specs/blob/1ae810e0137cc5d175ace4554892a4f43052be56/api/starknet_trace_api_openrpc.json#L11
 func (h *Handler) LegacyTraceTransaction(ctx context.Context, hash felt.Felt) (json.RawMessage, *jsonrpc.Error) {
-	return h.traceTransaction(ctx, &hash, true)
+	trace, err := h.traceTransaction(ctx, &hash, true)
+	if err.Code == ErrTxnHashNotFound.Code {
+		err = ErrInvalidTxHash
+	}
+	return trace, err
 }
 
 func (h *Handler) traceTransaction(ctx context.Context, hash *felt.Felt, legacyTraceJSON bool) (json.RawMessage, *jsonrpc.Error) {
 	_, _, blockNumber, err := h.bcReader.Receipt(hash)
 	if err != nil {
-		return nil, ErrInvalidTxHash
+		return nil, ErrTxnHashNotFound
 	}
 
 	block, err := h.bcReader.BlockByNumber(blockNumber)

diff --git a/rpc/handlers_test.go b/rpc/handlers_test.go
@@ -2821,7 +2821,7 @@ func TestTraceTransaction(t *testing.T) {
 
 		trace, err := handler.TraceTransaction(context.Background(), *hash)
 		assert.Nil(t, trace)
-		assert.Equal(t, rpc.ErrInvalidTxHash, err)
+		assert.Equal(t, rpc.ErrTxnHashNotFound, err)
 	})
 	t.Run("ok", func(t *testing.T) {
 		hash := utils.HexToFelt(t, "0x37b244ea7dc6b3f9735fba02d183ef0d6807a572dd91a63cc1b14b923c1ac0")