Add output field to vm.ComputationResources (#2096)

NethermindEth · Aug 28, 2024 · 54e20a6 · 54e20a6
1 parent 0f2d88b
commit 54e20a6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/adapters/vm2core/vm2core.go b/adapters/vm2core/vm2core.go
@@ -21,7 +21,7 @@ func AdaptExecutionResources(resources *vm.ExecutionResources) *core.ExecutionRe
 			Keccak:       resources.Keccak,
 			Poseidon:     resources.Poseidon,
 			SegmentArena: resources.SegmentArena,
-			Output:       0, // todo(kirill) recheck, add Output field to core?
+			Output:       resources.Output,
 			AddMod:       resources.AddMod,
 			MulMod:       resources.MulMod,
 			RangeCheck96: resources.RangeCheck96,

diff --git a/adapters/vm2core/vm2core_test.go b/adapters/vm2core/vm2core_test.go
@@ -75,19 +75,17 @@ func TestAdaptExecutionResources(t *testing.T) {
 			Pedersen:     1,
 			RangeCheck:   2,
 			Bitwise:      3,
-			Output:       0,
 			Ecsda:        4,
 			EcOp:         5,
 			Keccak:       6,
 			Poseidon:     7,
 			SegmentArena: 8,
+			Output:       11,
 		},
 		MemoryHoles: 9,
 		Steps:       10,
 	}, vm2core.AdaptExecutionResources(&vm.ExecutionResources{
 		ComputationResources: vm.ComputationResources{
-			Steps:        10,
-			MemoryHoles:  9,
 			Pedersen:     1,
 			RangeCheck:   2,
 			Bitwise:      3,
@@ -96,6 +94,9 @@ func TestAdaptExecutionResources(t *testing.T) {
 			Keccak:       6,
 			Poseidon:     7,
 			SegmentArena: 8,
+			MemoryHoles:  9,
+			Steps:        10,
+			Output:       11,
 		},
 	}))
 }
diff --git a/vm/trace.go b/vm/trace.go
@@ -235,6 +235,7 @@ type ComputationResources struct {
 	AddMod       uint64 `json:"add_mod_builtin,omitempty"`
 	MulMod       uint64 `json:"mul_mod_builtin,omitempty"`
 	RangeCheck96 uint64 `json:"range_check_96_builtin,omitempty"`
+	Output       uint64 `json:"output_builtin,omitempty"`
 }
 
 type DataAvailability struct {