Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New project structure proposal #12

Merged
merged 4 commits into from
Jan 27, 2022
Merged

New project structure proposal #12

merged 4 commits into from
Jan 27, 2022

Conversation

AntiD2ta
Copy link
Member

@AntiD2ta AntiD2ta commented Jan 27, 2022

Changes:

  • Project structure reshaped according to go standards and also nethermind standards on golang projects
  • Makefile added

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Further comments (optional)

See that the go.mod is changed. It is now on the root directory and it points out to github.com/NethermindEth/juno, as it should be

@AntiD2ta AntiD2ta self-assigned this Jan 27, 2022
@AntiD2ta AntiD2ta added the Optimisation New feature or request label Jan 27, 2022
@AntiD2ta AntiD2ta requested a review from tkstanczak January 27, 2022 05:05
@tkstanczak
Copy link
Member

@AntiD2ta that is great, I did not have a feel of it -> would you update the Juno with Go 1.17 GitHub action to successfully build now?

@AntiD2ta AntiD2ta merged commit f4b80e0 into main Jan 27, 2022
stdevMac pushed a commit that referenced this pull request Feb 9, 2022
@tkstanczak tkstanczak deleted the propose-new-structure branch February 9, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimisation New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants