Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Juno @task-5 #1870
Juno @task-5 #1870
Changes from 31 commits
787942a
9fe3466
8df2f60
aafed1c
bf778fb
b0cd907
a41b802
e09c801
301b7b9
7b66a6f
07a205f
ba7e1b0
6380352
c67cfd4
399b283
d472131
fc257c7
2e7918b
3fea2be
94fc3f8
4a1a516
893d38e
b49f2f5
368ae2d
c2ada93
c921837
248ef83
f5a1e6b
3bb8344
4e10777
55c94b5
59bcea5
eb55b94
6e6ae5e
547ee7b
d112f04
80bfba9
4dee1c3
be65415
c59c985
bf4c8e1
65aa53e
75f44c2
28f5516
26a8a03
fabef6a
05e983b
33a6d10
d4603b7
93c0612
372c7fd
3693d6f
29243b4
3d5a796
47642f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 151 in core/trie/trie.go
GitHub Actions / lint
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check failure on line 501 in rpc/handlers.go
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add another test where nodeStorage is not nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem to run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main issue is with
mocks
I am facing difficulty implementing:
Like I have to write this function right? It won't be auto-generated, right?
Please Have a look at this message:: Message