Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starknet.go tests to CI #1881

Closed
wants to merge 1 commit into from
Closed

Conversation

wojciechos
Copy link
Contributor

No description provided.

@wojciechos wojciechos requested a review from rianhughes May 28, 2024 08:51
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.37%. Comparing base (1f15377) to head (74e3a48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
+ Coverage   75.30%   75.37%   +0.07%     
==========================================
  Files          97       97              
  Lines        8332     8342      +10     
==========================================
+ Hits         6274     6288      +14     
  Misses       1522     1522              
+ Partials      536      532       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wojciechos wojciechos marked this pull request as draft May 28, 2024 09:25
@rianhughes
Copy link
Contributor

Looks good, but I think we should wait until starknet.go makes a release where all RPC0.7.0 tests pass

@derrix060
Copy link
Contributor

I'd say to just start ignoring the tests that are failing, this way it will be avoing people introducing regression

@derrix060
Copy link
Contributor

for example adding a "xfail", so it's expected to fail until someone fixes it

@derrix060 derrix060 deleted the wojciechos/starknet-go-tests branch September 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants