Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding exercises #1909

Closed
wants to merge 14 commits into from
Closed

Onboarding exercises #1909

wants to merge 14 commits into from

Conversation

artem-streltsov
Copy link
Contributor

Do not merge

pnowosie
pnowosie approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice work.
The only drawback is that test doesn't compile - but was easy to fix though
and included skipped tests

core/state.go Outdated Show resolved Hide resolved
core/trie/trie.go Outdated Show resolved Hide resolved
core/trie/trie.go Outdated Show resolved Hide resolved
rpc/block.go Outdated Show resolved Hide resolved
rpc/block_test.go Show resolved Hide resolved
@artem-streltsov artem-streltsov marked this pull request as ready for review June 27, 2024 18:18
@artem-streltsov artem-streltsov requested a review from pnowosie June 28, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnowosie pnowosie Awaiting requested review from pnowosie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artem-streltsov @pnowosie