Fixing some todos #1925
Merged
Fixing some todos #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdacap
reviewed
Jul 4, 2024
asdacap
reviewed
Jul 4, 2024
asdacap
reviewed
Jul 4, 2024
pnowosie
force-pushed
the
pnowosie/fixing-todos
branch
from
e889dd3 to
f6e7266
Compare
pnowosie
commented
Aug 1, 2024
asdacap
reviewed
Aug 1, 2024
asdacap
reviewed
Aug 1, 2024
pnowosie
force-pushed
the
pnowosie/fixing-todos
branch
2 times, most recently
from
55dbca7 to
d58ab63
Compare
|
Ok, I think we can merge it into |
pnowosie
force-pushed
the
pnowosie/fixing-todos
branch
from
d58ab63 to
bba9f68
Compare
asdacap
approved these changes
Aug 6, 2024
pnowosie
pushed a commit
that referenced
this pull request
Aug 8, 2024
This is a combination of 24 commits.
pnowosie
pushed a commit
that referenced
this pull request
Aug 16, 2024
This is a combination of 24 commits.
pnowosie
pushed a commit
that referenced
this pull request
Aug 19, 2024
weiihann
pushed a commit
that referenced
this pull request
Oct 25, 2024
weiihann
pushed a commit
that referenced
this pull request
Oct 28, 2024
pnowosie
pushed a commit
that referenced
this pull request
Nov 21, 2024
**This is a squash batch of 23 commits:** - Ashraf Basic snap algo .. Did something + #1925 - p2p client and looking at the syncService - finishing p2p handler - question - protobuf changes - snap server implements handler methods directly - fix snap server tests after refactor - refactor syncer to loop over iterator, add client message handling - p2p complete - no data exchange - Managed to sync ~200MB data - Fix: Trie iteration - test describing how storage of big contracts are responded - Storage ranges - fix unexpected contract change - Tweak message size params, trim logs - limit memory usage & verification - verification bug fix - Add sync mode p2p CLI flag (#2186) - Return struct instead of interface - Change flag usage string - Remove SnapServer interface - Revert makefile - Minor fixes - Update docs - Less logs, verification fixed - code improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.