Remove supported block version check #2275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojciechos
force-pushed
the
wojciechos/remove_versions_check
branch
3 times, most recently
from
e515322 to
da2f585
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2275 +/- ##
==========================================
- Coverage 75.45% 75.38% -0.08%
==========================================
Files 106 106
Lines 11237 11228 -9
==========================================
- Hits 8479 8464 -15
- Misses 2124 2128 +4
- Partials 634 636 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
wojciechos
force-pushed
the
wojciechos/remove_versions_check
branch
2 times, most recently
from
4cb2071 to
ba5e7b8
Compare
Allows processing of all versions without explicit checks
wojciechos
force-pushed
the
wojciechos/remove_versions_check
branch
from
ba5e7b8 to
d48baf2
Compare
wojciechos
commented
Nov 19, 2024
| @@ -382,7 +365,7 @@ func (b *Blockchain) VerifyBlock(block *core.Block) error { | |||
| } | |||
|
|
|||
| func verifyBlock(txn db.Transaction, block *core.Block) error { | |||
| if err := checkBlockVersion(block.ProtocolVersion); err != nil { | |||
| if _, err := core.ParseBlockVersion(block.ProtocolVersion); err != nil { | |||
There was a problem hiding this comment.
Wondering if we still need this or should also remove the block parsing check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows processing of all versions without explicit checks