Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce using cairo-lang-runner v2.8.5 and blockifier 0.8.0-rc.3 #2293

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

wojciechos
Copy link
Contributor

@wojciechos wojciechos commented Nov 28, 2024

Fix failing builds/tests in pipelines after silent libs upgrade. E.g: https://github.com/NethermindEth/juno/actions/runs/12070879412/job/33661352665#step:9:845

@wojciechos wojciechos force-pushed the wojciechos/fix-blockifier branch 3 times, most recently from 590866d to fd2024b Compare November 28, 2024 17:18
Copy link
Contributor

Minimum supported Rust version is 1.81.0, previous 1.80.1. Please update the README file, the Makefile, and this workflow.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.42%. Comparing base (874e86c) to head (9c8f679).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
- Coverage   75.45%   75.42%   -0.03%     
==========================================
  Files         107      107              
  Lines       11404    11404              
==========================================
- Hits         8605     8602       -3     
- Misses       2147     2149       +2     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wojciechos wojciechos force-pushed the wojciechos/fix-blockifier branch from fd2024b to 2766f40 Compare November 28, 2024 17:35
@wojciechos wojciechos changed the title Fixed blockifier version Enforce using cairo-lang-runner v2.8.0 Nov 28, 2024
@wojciechos wojciechos force-pushed the wojciechos/fix-blockifier branch from 2766f40 to c1a154d Compare November 28, 2024 17:40
@wojciechos wojciechos force-pushed the wojciechos/fix-blockifier branch from c1a154d to d627dbc Compare November 28, 2024 17:52
@wojciechos wojciechos changed the title Enforce using cairo-lang-runner v2.8.0 Enforce using cairo-lang-runner v2.8.5 Nov 28, 2024
Copy link
Contributor

Minimum supported Rust version is 1.81.0, previous 1.80.1. Please update the README file, the Makefile, and this workflow.

@wojciechos wojciechos marked this pull request as ready for review November 28, 2024 17:57
@wojciechos wojciechos changed the title Enforce using cairo-lang-runner v2.8.5 Enforce using cairo-lang-runner v2.8.5 and blockifier 0.8.0-rc.3 Nov 28, 2024
Copy link
Contributor

Minimum supported Rust version is 1.81.0, previous 1.80.1. Please update the README file, the Makefile, and this workflow.

@wojciechos wojciechos force-pushed the wojciechos/fix-blockifier branch from cfd560a to 9c8f679 Compare November 28, 2024 18:09
@kirugan kirugan merged commit d9dcf6c into main Nov 29, 2024
14 checks passed
@kirugan kirugan deleted the wojciechos/fix-blockifier branch November 29, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants