Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trace pending txns #2378

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix trace pending txns #2378

merged 1 commit into from
Jan 20, 2025

Conversation

wojciechos
Copy link
Contributor

@wojciechos wojciechos commented Jan 15, 2025

Fix support for tracing transactions in the pending block.

@wojciechos wojciechos force-pushed the wojciechos/fix-pending-trace branch 3 times, most recently from 88f0cb3 to e63c500 Compare January 15, 2025 07:51
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (d3ff578) to head (313c163).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
+ Coverage   74.68%   74.70%   +0.01%     
==========================================
  Files         111      111              
  Lines       12123    12123              
==========================================
+ Hits         9054     9056       +2     
+ Misses       2370     2368       -2     
  Partials      699      699              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from IronGauntlets/re-add-empty-pending to main January 15, 2025 11:26
@wojciechos wojciechos force-pushed the wojciechos/fix-pending-trace branch from e63c500 to 035a5f5 Compare January 15, 2025 12:32
@wojciechos wojciechos marked this pull request as draft January 15, 2025 12:37
@wojciechos wojciechos marked this pull request as ready for review January 15, 2025 12:42
@wojciechos wojciechos force-pushed the wojciechos/fix-pending-trace branch 6 times, most recently from 0b53960 to b232c49 Compare January 20, 2025 09:42
Co-authored-by: IronGauntlets <[email protected]>
@wojciechos wojciechos force-pushed the wojciechos/fix-pending-trace branch from b232c49 to 313c163 Compare January 20, 2025 10:01
Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wojciechos wojciechos merged commit 309e1ae into main Jan 20, 2025
17 of 19 checks passed
@wojciechos wojciechos deleted the wojciechos/fix-pending-trace branch January 20, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants