-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement starknet_getStorageProof
RPC
#2383
Open
weiihann
wants to merge
6
commits into
main
Choose a base branch
from
weiihann/get-storage-proof
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiihann
changed the title
Implement
Implement Jan 16, 2025
starknet_getStorageProof
starknet_getStorageProof
RPC
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2383 +/- ##
==========================================
- Coverage 74.65% 74.34% -0.32%
==========================================
Files 111 111
Lines 12123 12380 +257
==========================================
+ Hits 9051 9204 +153
- Misses 2372 2460 +88
- Partials 700 716 +16 ☔ View full report in Codecov by Sentry. |
thiagodeev
reviewed
Jan 16, 2025
weiihann
force-pushed
the
weiihann/get-storage-proof
branch
from
January 21, 2025 04:54
2f7a13d
to
6daf85e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2180
Implementation differs a lot from #2194, but tests are mostly imported from there.
Note that we currently do not support historical proofs, only the latest one.