Reduce number of allocations in p2p #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2388 +/- ##
==========================================
- Coverage 74.70% 74.68% -0.02%
==========================================
Files 111 111
Lines 12123 12123
==========================================
- Hits 9056 9054 -2
- Misses 2368 2370 +2
Partials 699 699 ☔ View full report in Codecov by Sentry. |
rodrigo-pino
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: instead of allocating response message on every iteration we allocate it once before iterations and reset it once we done with it after each iteration
Yesterday, I was watching a video about generics and thought that this function (particularly the reflection part) could be rewritten. Unfortunately, after 10 minutes of trial and error, I didn't succeed, but at least I found a way to reduce allocations and reflection calls.
Important: I haven't tested it fully, so please run p2p tests