Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ResourceBounds encoding #2398

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AnkushinDaniil
Copy link
Contributor

@AnkushinDaniil AnkushinDaniil commented Jan 24, 2025

This pull request includes updates to the Resource type in the rpc/transaction.go and starknet/transaction.go files to support a new resource type, ResourceL1DataGas.

Enhancements to resource handling:

  • rpc/transaction.go: Added ResourceL1DataGas to the Resource type and updated the MarshalText and UnmarshalJSON methods to handle this new resource. [1] [2] [3]
  • starknet/transaction.go: Updated the MarshalText method to handle the new ResourceL1DataGas resource.

@AnkushinDaniil AnkushinDaniil added RPC JSON RPC API go Pull requests that update Go code labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.45%. Comparing base (61d810a) to head (c99a65c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2398      +/-   ##
==========================================
- Coverage   74.48%   74.45%   -0.03%     
==========================================
  Files         113      113              
  Lines       13020    13026       +6     
==========================================
+ Hits         9698     9699       +1     
  Misses       2587     2587              
- Partials      735      740       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code RPC JSON RPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant