Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semaphore for websocket connection limit #2434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

weiihann
Copy link
Contributor

@weiihann weiihann commented Feb 7, 2025

@weiihann weiihann force-pushed the weiihann/fix-ws-limit branch from 94f602e to 834fdd6 Compare February 7, 2025 15:03
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.18%. Comparing base (668c093) to head (834fdd6).

Files with missing lines Patch % Lines
jsonrpc/websocket.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
+ Coverage   73.13%   73.18%   +0.04%     
==========================================
  Files         142      142              
  Lines       17095    17100       +5     
==========================================
+ Hits        12503    12514      +11     
+ Misses       3718     3711       -7     
- Partials      874      875       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant