fix: fix RpcDB connection so one can attach local Instance to remote DB for debugging purpose #8049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jan 14, 2025
Co-authored-by: Lukasz Rozmej <[email protected]>
MarekM25
reviewed
Jan 14, 2025
| @@ -96,7 +97,7 @@ private byte[] GetThroughRpc(ReadOnlySpan<byte> key) | |||
| byte[] value = null; | |||
| if (response.Result is not null) | |||
| { | |||
| value = Bytes.FromHexString((string)response.Result); | |||
| value = Bytes.FromHexString(response.Result.ToString()); | |||
There was a problem hiding this comment.
Cosmetic I prefer $"{response.Result}" for strings
| @@ -59,7 +59,7 @@ private DbSettings GetRocksDbSettings(DbSettings originalSetting) | |||
| bool firstDb = _index == -1; | |||
|
|
|||
| // if first DB, then we will put it into main directory and not use indexed subdirectory | |||
| string dbName = firstDb ? originalSetting.DbName : originalSetting.DbName + _index; | |||
| string dbName = originalSetting.DbName; | |||
There was a problem hiding this comment.
hmmm, my intuition is telling me that it could cause issues with full-pruning
There was a problem hiding this comment.
yeah wrote to Ashraf already as was not confident about this one
There was a problem hiding this comment.
But path still point to proper location - just DbName is different - without this change RPC was looking for a DB called "State0"
There was a problem hiding this comment.
Should be fine 'Path' is more important and 'Name' is mostly for our convenience. You might want to change FullPruningInnerDbFactoryTests.MatchSettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RpcDB mode - with proper configuration it allows to debug remote DB (or at least use some remote data and debug RPC calls issues).
To make it work, make sure local node runs with flags:
--Init.DiagnosticMode=RpcDb --Init.RpcDbUrl=JsonRPC URL (properly formatted with http:// as prefix)
Also enabling of debug rpc endpoints is needed as in background few debug calls are made to fetch from remote DB
Also for now it is quite slow (at least on my end) so worth applying --Init.ProcessingEnabled=false and disabling CL for processing on the desired node so will avoid messages about potential corruption of Db and will easily proceed to a enabled rpc node
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?