Nethermind UI (initial) #8109
Open
Nethermind UI (initial) #8109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1562
to
+1563
| var finalizedNumber = FindHeader(FinalizedHash, BlockTreeLookupOptions.DoNotCreateLevelIfMissing)?.Number; | ||
| var safeNumber = FindHeader(safeBlockHash, BlockTreeLookupOptions.DoNotCreateLevelIfMissing)?.Number; |
There was a problem hiding this comment.
potentially two lookups when we aren't sure if anyone is listening, seems wasteful?
There was a problem hiding this comment.
The ForkChoiceHandler has already looked them up; however need to work out how to plumb it through
| @@ -63,6 +63,7 @@ public sealed class BlockchainProcessor : IBlockchainProcessor, IBlockProcessing | |||
| private readonly Stopwatch _stopwatch = new(); | |||
|
|
|||
| public event EventHandler<IBlockchainProcessor.InvalidBlockEventArgs>? InvalidBlock; | |||
| public event EventHandler<BlockStatistics>? NewProcessingStatistics; | |||
There was a problem hiding this comment.
Can we just pass through add/remove for simplicity?
| @@ -41,3 +61,114 @@ public static void EnableConsoleColorOutput() | |||
| [DllImport("kernel32.dll")] | |||
| private static extern bool SetConsoleMode(IntPtr hConsoleHandle, uint dwMode); | |||
| } | |||
|
|
|||
|
|
|||
| public sealed class LineInterceptingTextWriter : TextWriter | |||
There was a problem hiding this comment.
Do we really need that? Doesn't NLog have something that would make it simpler for us?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
Documentation
Requires documentation update