New rpcdata + RPCv08 errors #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagodeev
force-pushed
the
thiagodeev/new-rpcdata
branch
2 times, most recently
from
f67c73f to
f9d13d8
Compare
thiagodeev
force-pushed
the
thiagodeev/new-rpcdata
branch
from
58ff990 to
2e444c3
Compare
rianhughes
reviewed
Jan 3, 2025
…and updating JSON marshaling/unmarshaling methods. Refactor ContractExecutionError to use ContractExecutionErrorInner for improved clarity.
thiagodeev
added a commit
that referenced
this pull request
Jan 13, 2025
commit 9199306 Author: thiagodeev <[email protected]> Date: Mon Jan 6 08:26:54 2025 -0300 Fixes failing test commit a6014d4 Merge: 9591073 1bd1947 Author: Thiago Ribeiro <[email protected]> Date: Mon Jan 6 08:18:12 2025 -0300 Merge branch 'main' into v0.8.0 commit 9591073 Author: Thiago Ribeiro <[email protected]> Date: Mon Jan 6 07:15:42 2025 -0300 New rpcdata + RPCv08 errors (#649) Update RPC rrror structure to handle RPv0.8.0 errors commit 1bd1947 Author: Thiago Ribeiro <[email protected]> Date: Wed Dec 18 13:00:30 2024 -0300 Creates a description for the multi-call feature (#648) * description of the multi call feature * Improves description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement some RPC v0.8.0 updates to starknet.go. The ones addressed by this PR are:
Components
CONTRACT_EXECUTION_ERROR
Errors
CONTRACT_ERROR
TRANSACTION_EXECUTION_ERROR
Note: As the RPC v0.8.0 has not yet been released, we can't fully test these changes as the nodes haven't implemented them yet. They will be updated before merging into main
Also, it improves the RPCError type. Now we have a way of returning the error message contained in the Data error field. We can also access it just by checking if it's nil or not.